Skip to content

ENG-1792: Add edit block button to rendered dg-canvas #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid597 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ENG-1792: Add edit block button to rendered dg-canvas #1203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0b4f7f
ENG-1792: Add edit block button to rendered dg-canvas
sid597 Jul 5, 2026
d53a010
ENG-1792: Type the block container lookup as nullable
sid597 Jul 6, 2026
9612e35
ENG-1792: Move edit button to bottom right of the canvas
sid597 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion apps/roam/src/components/canvas/CanvasEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import React from "react";
import { Button } from "@blueprintjs/core";
import posthog from "posthog-js";
import ExtensionApiContextProvider from "roamjs-components/components/ExtensionApiContext";
import { OnloadArgs } from "roamjs-components/types";
import renderWithUnmount from "roamjs-components/util/renderWithUnmount";
import getBlockUidFromTarget from "roamjs-components/dom/getBlockUidFromTarget";
import getUids from "roamjs-components/dom/getUids";
import getTextByBlockUid from "roamjs-components/queries/getTextByBlockUid";
import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTitle";
import { TldrawCanvas } from "./Tldraw";
Expand All @@ -28,6 +31,36 @@ const CanvasEmbedPlaceholder = ({ message }: { message: string }) => (
</div>
);

const handleEditBlock = (location: { blockUid: string; windowId: string }) => {
posthog.capture("Canvas Embed: Edit Block Clicked");
void window.roamAlphaAPI.ui.setBlockFocusAndSelection({
location: {
"block-uid": location.blockUid,
"window-id": location.windowId,
},
});
};

const CanvasEmbedChrome = ({
title,
location,
}: {
title: string;
location: { blockUid: string; windowId: string };
}) => (
<div className="relative h-full w-full">
<TldrawCanvas title={title} />
<Button
className="absolute bottom-2 right-8 z-20"
icon="edit"
minimal
small
title="Edit Block"
onClick={() => handleEditBlock(location)}
/>
Comment thread
sid597 marked this conversation as resolved.
</div>
);

export const renderCanvasEmbed = (
button: HTMLElement,
onloadArgs: OnloadArgs,
Expand All @@ -50,6 +83,8 @@ export const renderCanvasEmbed = (
return;
}

const location = getUids(button.closest<HTMLDivElement>(".roam-block"));

const wrapper = document.createElement("div");
wrapper.className = "dg-canvas-embed my-2 w-full overflow-hidden rounded-md";
wrapper.style.height = "400px";
Expand All @@ -58,7 +93,7 @@ export const renderCanvasEmbed = (

renderWithUnmount(
<ExtensionApiContextProvider {...onloadArgs}>
<TldrawCanvas title={title} />
<CanvasEmbedChrome title={title} location={location} />
</ExtensionApiContextProvider>,
wrapper,
);
Expand Down