Add 3D Model Viewer demo to the Windows bundle#13
Merged
Conversation
Wire the new displayxr-demo-modelviewer demo (v0.1.0) into the Windows meta-installer, mirroring gauss_demo at every touchpoint: - versions.json: pin modelviewer_demo = v0.1.0 - build-bundle.bat: component table entry, pin read + empty-check, bare version strip, download/find/copy, and /DMODELVIEWER_EXE + /DMODELVIEWER_VER makensis defines - DisplayXRBundleInstaller.nsi: !ifndef guards, G_ModelViewer* vars, SecModelViewer section under "Demos & samples", .onInit pre-check, LangString/description, and uninstaller chain entry (ARP key DisplayXRModelViewer) Windows-only: no macOS .pkg yet, so it is intentionally not added to the macOS path in build-bundle.sh (comment added there to that effect). makensis verified: compiles clean (13 sections). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the new
displayxr-demo-modelviewerdemo (first release v0.1.0) into the DisplayXR Windows meta-installer bundle, mirroring the existinggauss_democomponent exactly.Component facts
DisplayXR/displayxr-demo-modelviewerDisplayXRModelViewerSetup-*.exeSoftware\Microsoft\Windows\CurrentVersion\Uninstall\DisplayXRModelViewermodelviewer_demo=v0.1.03D Model ViewerChanges
versions.json— pinmodelviewer_demo=v0.1.0.scripts/build-bundle.bat— component table entry (COMPONENT_REPO_/EXE_modelviewer_demo), pin read + empty-check, bare-versionv-strip, download/find/copy steps, and/DMODELVIEWER_EXE+/DMODELVIEWER_VERmakensis defines.installer/windows/DisplayXRBundleInstaller.nsi— header doc line,!ifndef MODELVIEWER_EXE/VERguards,G_ModelViewerInstalled/G_ModelViewerVervars,Section "3D Model Viewer" SecModelViewerunder Demos & samples (exact structural mirror ofSecGauss),.onInitstate-init + pre-check,DESC_SecModelViewerLangString + description-text, and the uninstaller chain entry.scripts/build-bundle.sh— comment only; model viewer is Windows-only (no macOS.pkgyet), intentionally not added to the macOS path.Verification
makensissyntax check passes with dummy staged files (exit 0, no errors; only the expected empty-dummy-LICENSE warning). Section count went 12 → 13, confirmingSecModelViewerregistered.versions.jsonvalidated viajson.load.🤖 Generated with Claude Code