ci(windows): drop per-CI OneDrive uploads of runtime artifacts#420
Merged
Conversation
Build artifacts (runtime installer + test-apps zip) were rclone-copied to OneDrive on every non-fork CI run. Remove both rclone groups — the Runtime job's installer upload and the BundleTestApps job's test-apps-zip upload. OneDrive now receives the *bundle* meta-installer only, on release, from DisplayXR/displayxr-installer's publish-bundle.yml (workflow_dispatch-only). Reviewers still get artifacts via upload-artifact; release assets still attach to the GitHub Release on tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the two rclone → OneDrive upload groups from
build-windows.yml:DisplayXRSetup-*.exeinstaller uploadTestApps-<run#>.zipupload (incl. its OneDrive-only zip step)Both fired on every non-fork CI run (PRs, push to main, tags). They're gone.
Why
OneDrive should receive release artifacts only, not per-CI build output. The
companion PR on
displayxr-installer(ci/onedrive-bundle-upload) adds a singleOneDrive upload of the bundle meta-installer (
DisplayXRBundle-*.exe) topublish-bundle.yml, which isworkflow_dispatch-only — so the upload happens onrelease only.
Unchanged
upload-artifactsteps (reviewers still get the installer + test apps)Attach … to GitHub release on tagsteps🤖 Generated with Claude Code