ci(windows): compile test apps as a check, drop artifacts + release bundle#423
Merged
Conversation
…undle [#422] Test-app binaries served consumers who are going away: users don't run cube apps, devs build locally via the orchestrator, and DP-plugin authors have MSVC. Keep the apps as a compile check (they exercise the app-facing OpenXR/extension surface the headless selftest gate can't), but stop packaging them. - DetectChanges: gate test_apps on `test_apps/` only — drop the dead `demos/` watch (demos live in their own displayxr-demo-* repos). Stop forcing test_apps=true on tags (only fed the bundle); keep docs_only=false. - Remove all 11 per-app upload-artifact steps; jobs still compile + dumpbin-verify, just emit no binary. - Remove the BundleTestApps job (zip → upload → DisplayXR-TestApps-*.zip release attach). BumpVersionsJsonOnTag now needs: [Runtime]. - Doc consistency: CLAUDE.md, release/SKILL.md, versions-json-autobump.md. Conscious tradeoff: drops the prebuilt test-apps zip a toolchain-less vendor integrator could smoke-test against — accepted, DP authors build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #422.
Keeps test apps as a compile check in CI but stops packaging them — no per-CI artifacts, no
DisplayXR-TestApps-*.zipon releases. Follows the OneDrive-removal work (ci/onedrive-on-release-only, already on main).Rationale
Test-app binaries served consumers who are going away: end users don't run cube apps, developers build locally via the dev orchestrator, and anyone authoring a display-processor plug-in already has MSVC. The compile +
dumpbinarch-verify is the real signal — it's the only CI step that compiles the app-facing OpenXR/extension surface (client_*_compositor,xrSet*EXT, handle/texture/hosted paths) that the headlessselftestgate can't reach.Changes
test_apps/only; drop the deaddemos/watch (demos live indisplayxr-demo-*repos; in-treedemos/has no tracked files). Stop forcingtest_apps=trueon tags (only fed the bundle); still forcedocs_only=falseso Runtime + installer build.upload-artifactsteps. Jobs still checkout → download runtime → compile → copy DLLs →dumpbin-verify.BundleTestAppsentirely (download → zip → upload → versioned re-zip → release attach).BumpVersionsJsonOnTagnowneeds: [Runtime].CLAUDE.md,.claude/skills/release/SKILL.md(summary, workflow list, asset-verify check, final-report template),docs/specs/runtime/versions-json-autobump.md.Conscious tradeoff
Dropping the release-attached
DisplayXR-TestApps-*.zipremoves the only prebuilt smoke-test cubes a toolchain-less vendor integrator could use. Accepted — DP-plugin authors have a C++ toolchain. Re-adding a tag-only attach later is ~10 lines.Not in scope
Broadening the compile-check trigger to fire on runtime/extension-header changes (would add CI cost to every runtime PR). Can revisit with a small 2-app subset for a true ABI compile-gate.
Diff: +25 / −230. YAML validated.
🤖 Generated with Claude Code