chore(versions): register mediaplayer_demo (displayxr-demo-mediaplayer)#424
Merged
Conversation
Add the stereo media player demo to the hub so its v1.0.0 release can auto-bump and join the dev-orchestrator / meta-installer matrix: - versions.json: add "mediaplayer_demo" (placeholder v0.0.0; the demo's build-windows.yml dispatches versions-bump on its v* tag, which requires the field to pre-exist — the bump hard-fails on an unknown field). - scripts/lib/components.sh + setup-displayxr.bat: per-component asset table (macOS DisplayXRMediaPlayer-*.pkg, Windows DisplayXRMediaPlayerSetup-*.exe, install markers /Applications/Stereo Media Player.app and HKLM\Software\DisplayXR\Demos\MediaPlayer), mirroring gauss_demo. - dxr-release skill: add the `mediaplayer` / `demo-mediaplayer` component → config row + case resolver. The demo couples to the runtime via the OpenXR extension wire protocol only (no vendor SR SDK); this is just distribution metadata. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Registers the stereo media player demo (
DisplayXR/displayxr-demo-mediaplayer) in the hub so its imminent v1.0.0 release can auto-bump and join the dev-orchestrator / meta-installer matrix.The demo (M0–M6 complete; one Vulkan codebase across Windows/Linux/macOS, FFmpeg decode, subtle-3D ImGui UI) couples to the runtime via the OpenXR extension wire protocol only — no vendor SR SDK. This PR is pure distribution metadata.
Why now (the blocker)
The demo's
build-windows.ymldispatches aversions-bumpevent on itsv*tag withfield: "mediaplayer_demo".versions-bump.yml's apply step hard-fails on an unknown field (if leaf not in cur: sys.exit("versions.json has no field")). So the field must pre-exist here before the demo cutsv1.0.0, or the bump errors out and the demo never joins the bundle.Changes
versions.json— add"mediaplayer_demo": "v0.0.0"(placeholder; the demo's tag bump rewrites it tov1.0.0).scripts/lib/components.sh—mediaplayer_demoasset table (macOSDisplayXRMediaPlayer-*.pkg, WindowsDisplayXRMediaPlayerSetup-*.exe; markers/Applications/Stereo Media Player.app,HKLM\Software\DisplayXR\Demos\MediaPlayer), mirroringgauss_demo.scripts/setup-displayxr.bat— matching Windows per-component block..claude/skills/dxr-release/SKILL.md— add themediaplayer/demo-mediaplayerrow to the component→config map +caseresolver (so/dxr-release mediaplayer <ver>works).Verification
python3 -c 'json.load(open("versions.json"))'→ valid; keys now includemediaplayer_demo.components.sh;component_field mediaplayer_demo {REPO,PKG_MACOS,EXE_WINDOWS,INSTALL_MARKER_*}all resolve correctly.HKLM\Software\DisplayXR\Demos\MediaPlayer) and macOS bundle name (Stereo Media Player.app).Follow-up (separate, in displayxr-installer)
Adding the demo's
.pkgto the bundle composition (build-bundle.shextract_*/process_component, likegauss_demo) is a separate displayxr-installer change. Theversions.jsonmirror into displayxr-installer on the next bump already pins the demo.🤖 Generated with Claude Code