fix(orchestrator): modelviewer ships a macOS .pkg — stop skipping it on macOS#426
Merged
Conversation
…on macOS components.sh marked modelviewer_demo as macOS-unavailable (empty COMPONENT_PKG_MACOS / INSTALL_MARKER_MACOS), so --with-demos warn-skipped it on macOS. But the demo's build-macos.yml has attached DisplayXRModelViewer-*.pkg to every release since v0.3.0 (installs "/Applications/3D Model Viewer.app"). Populate the macOS glob + install marker from the real v0.7.0 artifact so --with-demos installs it on macOS too. Verified via --with-demos --dry-run: modelviewer_demo @ v0.7.0 now routes to install (was skip). mediaplayer_demo was already correct (glob + marker match its artifact). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #339. While prepping a real
--with-demosrun on macOS, found thatcomponents.shmarkedmodelviewer_demoas macOS-unavailable (emptyCOMPONENT_PKG_MACOS/INSTALL_MARKER_MACOS) — a stale leftover from when modelviewer was Windows-only.In reality the demo's
build-macos.ymlhas attachedDisplayXRModelViewer-*.pkgto every release since v0.3.0 (verified v0.3.0→v0.7.0; the pkg installs/Applications/3D Model Viewer.app). So--with-demoswas wrongly warn-skipping an installable demo on macOS.Populates the macOS glob + install marker from the real v0.7.0 artifact.
Verified via
./scripts/setup-displayxr.sh --with-demos --dry-run(macOS): all three demos now route to install —gauss_demo @ v1.6.0,modelviewer_demo @ v0.7.0(was skip),mediaplayer_demo @ v1.0.0.mediaplayer_demo's entry was already correct.🤖 Generated with Claude Code