Skip to content

fix(client/gl): don't toggle flip_y on window-space layers (#429) #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfattal merged 1 commit into from
Jun 5, 2026
Merged

fix(client/gl): don't toggle flip_y on window-space layers (#429) #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/xrt/compositor/client/comp_gl_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,17 @@ client_gl_compositor_layer_window_space(struct xrt_compositor *xc,

xscfb = to_native_swapchain(xsc);

struct xrt_layer_data d = *data;
d.flip_y = !d.flip_y;

return xrt_comp_layer_window_space(xcn, xdev, xscfb, &d);
/*
* No flip_y toggle here, unlike the other layer types: the
* window-space contract is that HUD pixels are uploaded top-down
* (D2D/CG row order, image top at texel row 0) regardless of client
* API, so the shared texture already matches the D3D11/Vulkan
* convention. The in-process GL compositor bakes that assumption
* into its window-space shader (ignores flip_y), and the D3D11
* service honors flip_y as a V-flip — toggling it here Y-flipped GL
* clients' HUDs on the IPC/workspace path (#429).
*/
return xrt_comp_layer_window_space(xcn, xdev, xscfb, data);
}

static xrt_result_t
Expand Down
Loading