Per-pixel surround click-through mask (#131)#136
Merged
Conversation
A 2D surround element with a non-rectangular shape (a comic bubble with a triangular tail) could only register a single bounding RECT for click-through (displayxr_set_overlay_surround_rect), so the transparent corners beside the tail caught clicks instead of routing to the desktop. Add displayxr_set_overlay_surround_mask(mask, mask_w, mask_h, dst_x,y,w,h): an owned per-pixel alpha mask of the element's exact shape, RLE-unioned into the SetWindowRgn region by displayxr_set_overlay_hit_mask using the same encoder as the tiger silhouette, mapped over its own dst rect. The empty area beside the shape stays click-through. The surround is flat post-weave 2D (no disparity / per-view union), so callers rasterize the mask directly on the CPU — no GPU silhouette pass. The single-rect API stays for compat; both are unioned in. Windows-only (displayxr_win32.c); macOS resolves via the C# EntryPointNotFound fallback like the existing surround-rect entry point. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 2D surround element with a non-rectangular shape (a comic bubble with a
triangular tail) could only register a single bounding RECT for click-through
(displayxr_set_overlay_surround_rect), so the transparent corners beside the
tail caught clicks instead of routing to the desktop.
Add displayxr_set_overlay_surround_mask(mask, mask_w, mask_h, dst_x,y,w,h): an
owned per-pixel alpha mask of the element's exact shape, RLE-unioned into the
SetWindowRgn region by displayxr_set_overlay_hit_mask using the same encoder as
the tiger silhouette, mapped over its own dst rect. The empty area beside the
shape stays click-through. The surround is flat post-weave 2D (no disparity /
per-view union), so callers rasterize the mask directly on the CPU — no GPU
silhouette pass. The single-rect API stays for compat; both are unioned in.
Windows-only (displayxr_win32.c); macOS resolves via the C# EntryPointNotFound
fallback like the existing surround-rect entry point.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com