ci: exclude CHANGELOG.md from vendor-name guard#8
Merged
Conversation
The guard exists to keep the active codebase vendor-neutral. CHANGELOG is the historical record; it can legitimately reference the original vendor SDK name (e.g. when describing pre-deprivatize work that was ported from the upstream vendor's plugin). Excluding it stops the guard from blocking every PR, while still catching new accidental vendor-name usage in code, docs, or config. Currently broken: every PR fails this job because CHANGELOG.md:12 mentions the original vendor SDK. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendor-name guard was rejecting CHANGELOG.md:12, which references the original vendor SDK as part of the historical record. Adding
--exclude=CHANGELOG.mdso the guard still catches new accidental vendor-name usage everywhere else but doesn't block on historical references.Currently breaks every PR (saw it on #6 and #7). After this lands, the lint job will go green and we can wire it as a required status check.