refactor: make Terminal.SCROLL_BACK_COUNT static final - #34
Merged
loki5512344 merged 1 commit intoSep 1, 2026
Annotations
10 warnings
|
Build and verify:
src/main/java/li/cil/oc2/common/bus/adapter/DeviceRegistry.java#L44
[UnnecessaryAsync] Variables which are initialized and do not escape the current scope do not need to worry about concurrency. Using the non-concurrent type will reduce overhead and verbosity.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/bus/adapter/RPCDeviceBusAdapter.java#L103
[LockNotBeforeTry] Prefer releasing the lock on pauseLock inside a finally block.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/TerminalDiff.java#L245
[EnumOrdinal] You should almost never invoke the Enum.ordinal() method or depend on the enum values by index.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/TerminalDiff.java#L73
[ArrayRecordComponent] Record components should not be arrays.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/TerminalDiff.java#L64
[ArrayRecordComponent] Record components should not be arrays.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/TerminalDiff.java#L63
[ArrayRecordComponent] Record components should not be arrays.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/TerminalDiff.java#L56
[MissingSummary] A summary line is required on public/protected Javadocs.
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/terminal/Terminal.java#L366
[ArrayRecordComponent] Record components should not be arrays.
|
|
Build and verify:
src/main/java/li/cil/oc2/client/renderer/cable/NetworkCableRenderer.java#L78
[ReferenceEquality] Comparison using reference equality instead of value equality
|
|
Build and verify:
src/main/java/li/cil/oc2/common/vm/video/DeltaFrameCodec.java#L396
[ByteBufferBackingArray] ByteBuffer.array() shouldn't be called unless ByteBuffer.arrayOffset() is used or if the ByteBuffer was initialized using ByteBuffer.wrap() or ByteBuffer.allocate().
|
background
wait
wait-all
cancel
parallel
Loading