Skip to content

getLocationsInArea function added - #40

Closed
BBrunekreeft wants to merge 4 commits into
DivideBV:masterfrom
BBrunekreeft:getLocationsInArea
Closed

getLocationsInArea function added#40
BBrunekreeft wants to merge 4 commits into
DivideBV:masterfrom
BBrunekreeft:getLocationsInArea

Conversation

@BBrunekreeft

@BBrunekreeft BBrunekreeft commented Feb 27, 2017 •
edited
Loading

Copy link
Copy Markdown

Retrieves PostNL Locations in specific area.
Code Example:

$coordinatesNorthWest = \DivideBV\Postnl\ComplexTypes\Coordinate::create()
    ->setLongitude(5.085307)
    ->setLatitude(52.118860);
$coordinatesSouthEast = \DivideBV\Postnl\ComplexTypes\Coordinate::create()
    ->setLongitude(5.135604)
    ->setLatitude(52.079527);
$locations = $postNL->getLocationsInArea(
    $coordinatesNorthWest,
    $coordinatesSouthEast,
    'false',
    null,
    ['PG', 'PGE'],
    ['Daytime'],
    'NL');

ameenross
ameenross reviewed Feb 28, 2017
View reviewed changes

@ameenross ameenross left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the contribution. Please have a look at CONTRIBUTING.md. Check your code style. Also, I'd like the commits to be a bit more descriptive.

Comment thread src/Postnl.php Outdated
Comment thread src/Postnl.php Outdated
@BBrunekreeft
Type hints
f17c15c 
Use type hints for parameters $coordinatesNorthWest and $coordinatesSouthEast in function getLocationsInArea()
@BBrunekreeft
Use factory with method chaining
6eb32da 
Use ComplexTypes\LocationArea::create() with method chaining in function getLocationsInArea.
Give default value to $deliveryDate if deliverydate is null
@slokhorst

slokhorst commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

I would like to use this function. Is there any more work needed?

@BBrunekreeft

BBrunekreeft commented Jul 13, 2017

Copy link
Copy Markdown
Author

No more work needed

ameenross
ameenross reviewed Jul 14, 2017
View reviewed changes
Comment thread src/Postnl.php
@ameenross

ameenross commented Jul 14, 2017

Copy link
Copy Markdown
Contributor

Sorry for the delay, I'd like to get this merged soon

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ameenross ameenross ameenross left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BBrunekreeft @slokhorst @ameenross