Skip to content

๐Ÿž Fix: ๋ชจ๋ฐ”์ผ ์•ฑ ์†Œ์…œ ๋กœ๊ทธ์ธ ์ฝœ๋ฐฑ ์ฒ˜๋ฆฌ ์ถ”๊ฐ€ - #65

Merged
sooloin merged 4 commits into
DoDo-Project:developfrom
sooloin:bug/mobile-oauth-callback
Aug 28, 2026
Merged

๐Ÿž Fix: ๋ชจ๋ฐ”์ผ ์•ฑ ์†Œ์…œ ๋กœ๊ทธ์ธ ์ฝœ๋ฐฑ ์ฒ˜๋ฆฌ ์ถ”๊ฐ€#65
sooloin merged 4 commits into
DoDo-Project:developfrom
sooloin:bug/mobile-oauth-callback

Conversation

@sooloin

@sooloin sooloin commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

๐Ÿ“„ ์ž‘์—… ๋‚ด์šฉ (Description)

์•ฑ(dodo-app)์—์„œ ๊ตฌ๊ธ€/๋„ค์ด๋ฒ„ ๋กœ๊ทธ์ธ์ด ์•ˆ ๋˜๋˜ ๋ฌธ์ œ ์ˆ˜์ •. ์•ˆ๋“œ๋กœ์ด๋“œ๊ฐ€ OAuth
์„œ๋ฒ„์˜ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ๋กœ ์ปค์Šคํ…€ URI ์Šคํ‚ด(dodoapp://)์„ ์ง์ ‘ ๋ฐ›๋Š” ๊ฑธ ์ •์ฑ…์ƒ ์ฐจ๋‹จํ•ด์„œ
์ƒ๊ธด ๋ฌธ์ œ๋กœ, ์•ฑ ์ชฝ์—์„œ ์ž์ฒด์ ์œผ๋กœ ํ•ด๊ฒฐ์ด ๋ถˆ๊ฐ€๋Šฅํ•ด ์ฝœ๋ฐฑ์ด ๋„์ฐฉํ•˜๋Š” ํ”„๋ก ํŠธ
(/auth/callback/:provider)์—์„œ ์•ฑ๋ฐœ ์š”์ฒญ์„ ๊ฐ์ง€ํ•ด ๋”ฅ๋งํฌ๋กœ ๋„˜๊ฒจ์ฃผ๋Š” ๋‹ค๋ฆฌ ์—ญํ• ์„
์ถ”๊ฐ€ํ•จ.

  • state ๊ฐ’์ด app_ ์ ‘๋‘์‚ฌ๋กœ ์‹œ์ž‘ํ•˜๋ฉด(=์•ฑ์—์„œ ๋งŒ๋“  ์š”์ฒญ) dodoapp://auth/callback/{provider}๋กœ ์žฌ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ
  • ์›น ์ž์ฒด ๋กœ๊ทธ์ธ ํ๋ฆ„(state๊ฐ€ ์ˆœ์ˆ˜ UUID)์€ ์ด ๋ถ„๊ธฐ์™€ ์ ˆ๋Œ€ ๊ฒน์น˜์ง€ ์•Š์Œ โ€” ์ฝ”๋“œ ๋ณ€๊ฒฝ ์—†์Œ, ์กฐ๊ฑด๋ฌธ ํ•˜๋‚˜ ์ถ”๊ฐ€

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ (Related Issues)

  • ๊ธ‰ํ•œ ๊ฑด์ด๋ผ ์ด์Šˆ ์—†์ด ์ง„ํ–‰ (ํ•„์š”์‹œ ์‚ฌํ›„ ์ด์Šˆ ์ƒ์„ฑ)

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ (Checklist)

  • PR ์ œ๋ชฉ์€ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ๋”ฐ๋ž์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ์ด์Šˆ๋ฅผ ์—ฐ๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค. โ€” ์ด์Šˆ ์ƒ๋žต
  • ์Šค์Šค๋กœ ์ฝ”๋“œ๋ฅผ ๊ฒ€ํ† ํ•˜๊ณ  ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ฝ”๋“œ ์Šคํƒ€์ผ์ด ํ”„๋กœ์ ํŠธ ๊ทœ์น™๊ณผ ์ผ์น˜ํ•ฉ๋‹ˆ๋‹ค.
  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ–ˆ๊ฑฐ๋‚˜, ๊ธฐ์กด ํ…Œ์ŠคํŠธ๊ฐ€ ๋ชจ๋‘ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค. โ€” ๋ถ„๊ธฐ ๋กœ์ง๋งŒ ์ถ”๊ฐ€, ๋ณ„๋„ ํ…Œ์ŠคํŠธ ์—†์Œ

๐Ÿ’ฌ ๊ธฐํƒ€ ์‚ฌํ•ญ (Etc)

์•ฑ(dodo-app) ์ชฝ๋„ ๊ฐ™์ด ์ˆ˜์ •๋จ โ€” ๋„ค์ดํ‹ฐ๋ธŒ Google Sign-In SDK ์ œ๊ฑฐํ•˜๊ณ  ์ด ํ”Œ๋กœ์šฐ์—
๋งž์ถฐ ๋ธŒ๋ผ์šฐ์ € ๊ธฐ๋ฐ˜ ๋กœ๊ทธ์ธ์œผ๋กœ ํ†ต์ผ. ์•ฑ ์•ˆ๋“œ๋กœ์ด๋“œ ๋ฆฌ๋นŒ๋“œ๋Š” ๋ณ„๋„๋กœ ์ง„ํ–‰ ์ค‘.

sooloin and others added 4 commits June 23, 2026 18:38
- ์•ˆ๋“œ๋กœ์ด๋“œ๊ฐ€ OAuth ์„œ๋ฒ„(Google/Naver)์˜ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ๋กœ ์ปค์Šคํ…€ URI ์Šคํ‚ด์„ ์ง์ ‘
  ๋ฐ›๋Š” ๊ฑธ ์ฐจ๋‹จํ•ด์„œ, ์•ฑ์—์„œ ๋กœ๊ทธ์ธ ์‹œ๋„ ์‹œ ์ฝœ๋ฐฑ์„ ๋ฐ›์ง€ ๋ชปํ•˜๋˜ ๋ฌธ์ œ
- AuthCallbackPage์—์„œ state ๊ฐ’์ด 'app_' ์ ‘๋‘์‚ฌ๋กœ ์‹œ์ž‘ํ•˜๋ฉด ๋ชจ๋ฐ”์ผ ์•ฑ
  (dodo-app)์—์„œ ์‹œ์ž‘๋œ ์š”์ฒญ์œผ๋กœ ํŒ๋‹จํ•ด code/state/error๋ฅผ dodoapp://
  ์ปค์Šคํ…€ ์Šคํ‚ด์œผ๋กœ ๊ทธ๋Œ€๋กœ ์žฌ์ „๋‹ฌํ•˜๋„๋ก ๋ถ„๊ธฐ ์ถ”๊ฐ€
- ์•ฑ์˜ ์ธ์•ฑ ๋ธŒ๋ผ์šฐ์ €๋Š” ๋ณ„๋„ ์„ธ์…˜์ด๋ผ ๊ธฐ์กด sessionStorage ๊ธฐ๋ฐ˜ state
  ๊ฒ€์ฆ ๋กœ์ง์„ ํƒ€์ง€ ์•Š๊ณ  ๋ฐ”๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ
- ์›น ์ž์ฒด ๋กœ๊ทธ์ธ ํ๋ฆ„์€ ์˜ํ–ฅ ์—†์Œ โ€” ์›น์˜ state๋Š” crypto.randomUUID()๋ผ
  'p' ๋ฌธ์ž๊ฐ€ ๋‚˜์˜ฌ ์ˆ˜ ์—†์–ด 'app_' ๋ถ„๊ธฐ์™€ ์ ˆ๋Œ€ ๊ฒน์น˜์ง€ ์•Š์Œ
@sooloin
sooloin requested a review from WhiteBin-bin August 28, 2026 01:30
@sooloin sooloin self-assigned this Aug 28, 2026
@sooloin sooloin added ๐Ÿž Fix ์„œ๋ฒ„ ์˜ค๋ฅ˜, ๋ฐ์ดํ„ฐ ๋ถˆ์ผ์น˜ ๐Ÿ˜ธ ์กฐ์ˆ˜๋นˆ ์กฐ์ˆ˜๋นˆ ํŒŒํŠธ labels Aug 28, 2026
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@sooloin is attempting to deploy a commit to the sooloin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dodo-frontend Ready Ready Preview Aug 28, 2026 1:32am
dodo-web Ready Ready Preview Aug 28, 2026 1:32am

@sooloin
sooloin merged commit 4965d11 into DoDo-Project:develop Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿž Fix ์„œ๋ฒ„ ์˜ค๋ฅ˜, ๋ฐ์ดํ„ฐ ๋ถˆ์ผ์น˜ ๐Ÿ˜ธ ์กฐ์ˆ˜๋นˆ ์กฐ์ˆ˜๋นˆ ํŒŒํŠธ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant