Skip to content

fix: fail-fast on missing AI API key — prevent silent credential fall…#38

Merged
Doble-2 merged 1 commit into
mainfrom
fix/33-api-key-null-guard
Jun 15, 2026
Merged

fix: fail-fast on missing AI API key — prevent silent credential fall…#38
Doble-2 merged 1 commit into
mainfrom
fix/33-api-key-null-guard

Conversation

@Doble-2

@Doble-2 Doble-2 commented Jun 15, 2026

Copy link
Copy Markdown
Owner

…back

  • AgentEngine.run() raises ValueError when ai_api_key is None/empty
  • build_deepseek_client() also validates key before constructing client
  • Doctor check updated: flags missing key as warning for agent mode
  • 4 new tests verify error is raised before any LLM call

Closes #33

…back

- AgentEngine.run() raises ValueError when ai_api_key is None/empty
- build_deepseek_client() also validates key before constructing client
- Doctor check updated: flags missing key as warning for agent mode
- 4 new tests verify error is raised before any LLM call

Closes #33
@Doble-2 Doble-2 merged commit 7ba28c1 into main Jun 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AgentEngine passes api_key=None to OpenAI SDK — silently falls back to OPENAI_API_KEY environment variable, misdirecting credentials

1 participant