Development#45
Merged
Merged
Conversation
…egatives - Sherlock runner: log errors at DEBUG, return (profiles, error_count) - Site-list runner: log errors at DEBUG, return (profiles, error_count) - identity_pipeline safe_scan: log errors at DEBUG, remove # pragma: no cover - PipelineResult gains scan_errors field for aggregate error count - Pipeline emits warning when errors occurred: 'N scanner(s) returned errors' - 7 new tests: error counting, safe_scan fallback path coverage Closes #34
Fix/34 scanner error observability
…ent engine, and tools New test files: - test_hunt_pipeline.py: hunt() orchestration, expansion loop, sherlock/site-list/breach integration, deduplication (6 tests) - test_osint_scanners.py: 6 scanners (X, GitLab, GitHub, Reddit, Keybase, Telegram) with mocked HTTP, positive/negative matches (12 tests) - test_agent_engine_loop.py: AgentEngine.run() with mocked LLM, max steps, forced report, error handling, callbacks (5 tests) - test_agent_tools_execution.py: execute_tool() dispatch for all 5 tools + edge cases (14 tests) - test_resources_loader.py: load_sherlock_data cached/download/failure, get_default_list_path (7 tests) - test_profile_enricher.py: enrichment, skip logic, error handling (5 tests) - test_sherlock_runner_integration.py: status_code/message errorType, NSFW filtering, progress callback (6 tests) Total: 184 → 238 tests (+54), zero regressions. Closes #32
test: add comprehensive test coverage for core pipeline, scanners, ag…
On development branch, run_sherlock_username returns (list, error_count) tuple instead of just a list. Updated all sherlock tests to use isinstance(result, tuple) guard for compatibility with both branches.
fix: handle tuple return from run_sherlock_username (#34 compat)
Use inspect.getsource(hunt) to detect whether the pipeline does tuple unpacking (development) or profiles.extend() (main), and set the mock return value accordingly.
fix: auto-detect sherlock return format for main/development compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.