Development#48
Merged
Merged
Conversation
#27) - Change proxy_api_key and ai_api_key to pydantic SecretStr in AppSettings so model_dump()/repr() never expose raw key values. - Refactor _build_proxy_url() to return (base_url, auth_tuple) instead of embedding credentials in the URL string. - Use httpx.Proxy(url, auth=...) so credentials are never in exception messages, debug logs, or tracebacks. - Update all consumers (agent_engine, ai_analyst, CLI, doctor) to use .get_secret_value() where the raw string is needed. - Add 5 new SecretStr redaction tests verifying model_dump, repr, and URL string safety. Closes #27
security: remove API key from proxy URL, use SecretStr for credential…
Without proxy_username, the endpoint is proxy.scrapingant.com (not residential.scrapingant.com). Check 'residential' in auth username instead of URL.
fix: correct auto-detect test assertion for API proxy endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.