Change default styling of an open <endpoint> to have an opaque interior#1323
Change default styling of an open <endpoint> to have an opaque interior#1323KhoiUna wants to merge 4 commits into
Conversation
|
Great, @KhoiUna, this is a good start. Indeed for a point that starts open, such as The next step is address the case where the openness of the point changes dynamically. The easiest way to see that is to add the To determine how to change it dynamically, you can look at the code starting on line 504 of The case invoked by the Note: when modifying a jsxgraph property like |
|
Also, could you assign issue #184 to yourself? Then, edit the PR description to give a short description of what the PR does. At the end of the description, add the line |
dqnykamp
left a comment
There was a problem hiding this comment.
See the above comments for the requested changes.
@dqnykamp I do not think I have the permission to assign the issue to myself. |
I see. I assigned it to you. |
|
@dqnykamp I have made some tweaks. Could you please review? |
What does this PR do? Fixes the default styling of an open
<endpoint>by ensuring its interior renders as opaque rather than transparent.Why was this PR needed? Issue #184 reported that background grid lines and other graphic elements leak through open endpoints, causing visual clutter. Investigation of
point.tsxrevealed that the rendering logic lacked a fallback opaque fill rule for open symbols during both initialization and dynamic state changes.What are the relevant issue numbers? Closes #184
Does this PR meet the acceptance criteria?: