IDEV-2578: add all available parameters for feeds in CLI - #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domaintools/api.py(docstrings, no signature changes — all feed methods use**kwargs)# Session Management Parameters,# Filter Parameters,# Result formatting parameters) to all 9 feed methods:nod,nad,noh,domaindiscovery,domainrdap,realtime_domain_risk,domainhotlist,iphotlist,iprisk.before(int-1to-432000or ISO 8601, 5-day max window) andfromBeginning(requiressessionID, HTTP 406/422 semantics) across all feeds.overall_min,malware_min,phishing_min,spam_min,proximity_min, range1-99, logical AND) torealtime_domain_riskanddomainhotlist.iphotlist/iprisk:pdns_resolutions_min,bad_pdns_resolutions_min,total_domains_maxthird_party_threats_min,all_threats_combined_percent_min,combined_phishing_percent_min,combined_malware_percent_min,combined_spam_percent_minall_threats_percent_min,percent_phishing_min,percent_malware_min,percent_spam_minasn,organization,country_codedomainrdap: docstring caveat that it's JSON-only, and the method now actively popsoutput_format/headersfrom kwargs before the request (client-side enforcement, not just documentation) — so CSV/headers can never be sent to that endpoint even if requested.domaintools/cli/commands/feeds.py--frombeginning/-fboption to all feeds that lacked it (nad,nod,noh,domaindiscovery,domainrdap,domainhotlist,realtime_domain_risk).--format/--headers/--topinto "Result formatting parameters".--overall-min/--malware-min/--phishing-min/--spam-min/--proximity-mintodomainhotlistandrealtime_domain_risk.--pdns-resolutions-min,--asn,--country-code, etc.) toiphotlistandiprisk.domainrdapcommand has no--format/--headersoptions at all.README.mdfromBeginningusage example, IP feed filter groups.