Skip to content

IDEV-2578: add all available parameters for feeds in CLI - #205

Merged
cpanares merged 1 commit into
release-v2.10.0from
IDEV-2578-update-feeds-parameters
Aug 19, 2026
Merged

IDEV-2578: add all available parameters for feeds in CLI#205
cpanares merged 1 commit into
release-v2.10.0from
IDEV-2578-update-feeds-parameters

Conversation

@cpanares

Copy link
Copy Markdown
Contributor

domaintools/api.py (docstrings, no signature changes — all feed methods use **kwargs)

  • Added categorized docstring sections (# Session Management Parameters, # Filter Parameters, # Result formatting parameters) to all 9 feed methods: nod, nad, noh, domaindiscovery, domainrdap, realtime_domain_risk, domainhotlist, iphotlist, iprisk.
  • Documented before (int -1 to -432000 or ISO 8601, 5-day max window) and fromBeginning (requires sessionID, HTTP 406/422 semantics) across all feeds.
  • Added the 5 risk filters (overall_min, malware_min, phishing_min, spam_min, proximity_min, range 1-99, logical AND) to realtime_domain_risk and domainhotlist.
  • Added 15 new IP-specific filters to iphotlist/iprisk:
    • pdns_resolutions_min, bad_pdns_resolutions_min, total_domains_max
    • third_party_threats_min, all_threats_combined_percent_min, combined_phishing_percent_min, combined_malware_percent_min, combined_spam_percent_min
    • all_threats_percent_min, percent_phishing_min, percent_malware_min, percent_spam_min
    • asn, organization, country_code
  • domainrdap: docstring caveat that it's JSON-only, and the method now actively pops output_format/headers from kwargs before the request (client-side enforcement, not just documentation) — so CSV/headers can never be sent to that endpoint even if requested.

domaintools/cli/commands/feeds.py

  • Added --frombeginning/-fb option to all feeds that lacked it (nad, nod, noh, domaindiscovery, domainrdap, domainhotlist, realtime_domain_risk).
  • Reorganized every command's options under the three category comments; moved --format/--headers/--top into "Result formatting parameters".
  • Added --overall-min/--malware-min/--phishing-min/--spam-min/--proximity-min to domainhotlist and realtime_domain_risk.
  • Added the 15 IP filter flags (--pdns-resolutions-min, --asn, --country-code, etc.) to iphotlist and iprisk.
  • domainrdap command has no --format/--headers options at all.

README.md

  • New "Feed parameters" section documenting all three categories, including risk filters, fromBeginning usage example, IP feed filter groups.

@briluza briluza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ nice job @cpanares !

@cpanares
cpanares merged commit 8c01ff8 into release-v2.10.0 Aug 19, 2026
16 checks passed
@cpanares
cpanares deleted the IDEV-2578-update-feeds-parameters branch August 19, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants