[IDEV-2584] RTTF Support for header authentication & CLI Improvements for download endpoint - #206
Merged
Conversation
…nd CLI output; add --limit/--page/--prefix to feed commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: RTTF API key no longer leaks as a plain query param.** When
header_authenticationis active (the default for all Real-Time Threat Feed endpoints),api_keyis now sent exclusively via theX-Api-Keyheader and is removed from query parameters.Fix:
endpoint=downloadno longer requires time params.validate_feeds_parameterswas erroneously requiringsessionID/after/beforefor download calls. Download endpoints don't use a session window, so the check is now skipped whenendpoint=download.Fix: download endpoint now returns correct result type and response shape. All 9 feed methods (
nod,nad,noh,domainrdap,domaindiscovery,realtime_domain_risk,domainhotlist,iphotlist,iprisk) previously returned a streamingFeedsResultsfor the download path. They now return a standardResultswithresponse_path=("response",), matching the actual JSON shape of the download API.Fix: feed-specific params no longer leak into download requests. Download path calls now only forward
limit/page/prefix; stream-only params (sessionID,after,domain, etc.) are no longer included.CLI: added
--limitto all 9 feed commands. Previously missing from the CLI surface; only applies toendpoint=download.Fix: CLI download output now renders as JSON. The download endpoint response was previously printed as a Python dict repr (
{'key': ...}) because the formatter treated it as a streaming feed. It now correctly formats as JSON.Updated
PYTHON_SUPPORT.mdto reflect the Python >=3.9 requirement.Updated
README.mdFeeds section:header_authenticationdefaults toFalsefor download endpoints — it isTruefor all RTTF endpoints.limit,page,prefixparameter documentation under a new "Download-only parameters" subsection.topis ignored for the download endpoint.