Skip to content

docs: add v9 section for strong-name signing - #260

Closed
Dor-bl wants to merge 2 commits into
mainfrom
docs/readme-v9-strong-naming
Closed

Dor-bl wants to merge 2 commits into
mainfrom
docs/readme-v9-strong-naming

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Sep 16, 2026

Copy link
Copy Markdown
Owner

PR title

docs: — README-only change, no code/behavior change.

Related issue

Closes # n/a

List of changes

  • Added a ## v9 section to the README (placed above ## v8, following the existing per-major-version pattern) documenting that Appium.Net is strong-name signed as of 9.0.0, with the public key token, the Selenium 4.44.0 parity note, and links to #1066 and #1118.
  • Replaced the shorter strong-naming blurb that already lived under the ## NuGet section with a one-line pointer to the new ## v9 section, so the same notice isn't duplicated in two places.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Refactoring (non-breaking change that improves code without altering functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • New test coverage (non-breaking change that adds tests for existing, previously untested functionality)
  • Test fix (non-breaking change that improves test stability or correctness)
  • Chore/Maintenance (updates to build scripts, dependencies, or GitHub Actions)

Tests

  • No automated tests (explain why below)

How they run: n/a — README-only documentation change.

Documentation

  • Have you proposed a file change/PR with Appium to update documentation?
  • Not applicable (no user-facing behaviour change, e.g. tests, CI or maintenance only)

Details

This documents the strong-name signing change already merged in #1118, giving it its own versioned section in the README (matching the existing ## v8 / ## v5 sections) instead of only a short note under ## NuGet.

Supersedes #259 (same change, rebranched off docs/readme-v9-strong-naming instead of claude/tender-feynman-9317dw).

🤖 Generated with Claude Code


Generated by Claude Code

Document the Appium.Net strong-name signing change from appium#1118 as its
own versioned section, matching the existing v8/v5 pattern. Also
dedupe the shorter blurb that already lived under NuGet by pointing
it at the new v9 section instead of repeating the same notice.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 16, 2026

Dor-bl commented Sep 16, 2026

Copy link
Copy Markdown
Owner Author

android-tests (32, google_apis) is failing, but not because of this PR's change (this PR only touches README.md). The job dies during setup, before any test runs:

Warning: Failed to find package 'tools'
Error: The process '/usr/local/lib/android/sdk/cmdline-tools/20.0/bin/sdkmanager' failed with exit code 1

That's the android-actions/setup-android step failing to fetch the Android SDK tools package — infrastructure outside this repo, not something a code/docs change here can affect. It reproduced identically across two independent runs (this PR's and its predecessor #259, both against the same base). No fix exists to port for this; I'll re-run the job once it's safe to (workflow run needs to fully complete first) to see if it clears on retry.


Generated by Claude Code

Dor-bl commented Sep 16, 2026

Copy link
Copy Markdown
Owner Author

ios-tests also failed on this run, also for a reason unrelated to this PR's README-only change:

OneTimeSetUp: SetUp : OpenQA.Selenium.UnknownErrorException : The simulator F0E646EF-4792-4F36-B48B-EC89B3A6B73B has failed to finish booting after 120s.

That's an iOS Simulator boot timeout in AlertTests.BeforeAll() — infrastructure, not a test regression. Re-running both failed jobs (android-tests, ios-tests) once now.


Generated by Claude Code

Dor-bl commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the merged upstream PR: appium/dotnet-client#1125. Closing this fork PR — the fork's main will be synced to pick up the merged change.


Generated by Claude Code

@Dor-bl Dor-bl closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant