fix: double terminal prompt + StageStrip state management#45
Open
felixflores wants to merge 4 commits into
Open
fix: double terminal prompt + StageStrip state management#45felixflores wants to merge 4 commits into
felixflores wants to merge 4 commits into
Conversation
- Add fresh_session flag to KuboExecBackend to skip capture-pane for newly created tmux sessions (prevents duplicate prompt) - Convert StageStrip from StatefulWidget to ConsumerStatefulWidget - Replace 19 prop-drilled parameters with direct provider watches - Sidebar tab state now single-sourced from sidebarProvider - Variant actions (dismiss/integrate/discard) call providers directly - Add regression test for pre_populate + push duplicate scenario
StageStrip now owns its own dialogs, provider mutations, and file picker calls internally. FacetShell's StageStrip construction drops from 18 lines to 4 (cardKeys + onScroll + onToggleCollapse). Actions moved: focusFacet, openSession, deleteSession, addAbotToKubo, createAbotSession, createNewKubo, openBundle, openBundleInKubo, openKuboFromDisk, removeAbotFromKubo, and the shared name dialog. FacetShell retains landing-page actions (used by KuboLandingPage and EmptyStateLandingPage) plus CSS-transform logic that only it can do.
- Add --host CLI flag for external hostname (WebAuthn RP origin) - Allow setup tokens for first passkey registration (remote) - Unwrap publicKey wrapper from webauthn-rs options for simplewebauthn - Use connect_with_local_defaults() for Docker (Colima compatibility) - Remove unused cred_count in register_options
- Delete browse.rs (native OS file/directory pickers) - Delete file_browser_dialog.dart (unused custom browser) - Remove /sessions/open, /kubos/open endpoints - Remove /api/browse, /api/pick-* endpoints - Remove config dir picker routes (/api/config/bundle-dir, kubos-dir) - Add download endpoints: GET /kubos/:name/download, /abots/:name/download - Add download button to kubo action bar in sidebar - Simplify settings panel (remove dir picker UI) - Simplify landing pages (remove "Open from disk" buttons) - Replace Save As native picker with name input dialog - Add flate2 + tempfile deps, tests for download module - Fix Docker socket test to skip when unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fresh_sessionflag toKuboExecBackendthat skips scrollback restoration for newly created sessionsStatefulWidgettoConsumerStatefulWidgetwatching Riverpod providers directly, fixing stale UI after abot dismissTest plan