Skip to content

Add source path metadata to configuration backups#461

Merged
DotDev262 merged 3 commits into
DotDev262:mainfrom
sat-06:feat/config-drift-detection
Jun 21, 2026
Merged

Add source path metadata to configuration backups#461
DotDev262 merged 3 commits into
DotDev262:mainfrom
sat-06:feat/config-drift-detection

Conversation

@sat-06

@sat-06 sat-06 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #444

Summary

Adds source configuration path metadata to WinHome configuration backups.

Changes

  • Added SourcePath field to backup metadata model.

  • Updated IConfigBackupService to accept a source configuration path.

  • Passed the active configuration file path from Program.cs during backup creation.

  • Persisted source path information in generated backup files.

  • Added unit tests for:

    • Backup file creation
    • Missing restore file handling
    • Source path metadata persistence

Testing

  • dotnet build
  • dotnet test

All tests pass successfully.

@github-actions github-actions Bot added level:intermediate Intermediate level task type:feature New feature GSSOC GirlScript Summer of Code 2026 labels Jun 19, 2026
@sat-06

sat-06 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Hey @DotDev262
I have implemented the solution for the issue.
All the tests passed locally.
Plz let me know if there are any changes from my side.

@DotDev262

Copy link
Copy Markdown
Owner

This PR adds SourcePath metadata to backups, which is a building block for #444 (Configuration Drift Detection). However, partial/split submissions for a single issue are not accepted — the full drift detection feature (comparison logic, reporting, CLI command) must be delivered in one PR.

Please either:

  1. Extend this PR to implement the complete drift detection feature (compare current vs. desired state, generate a report across supported config types).
  2. Close this PR and submit a single PR that implements the full scope of Add Configuration Drift Detection and Reporting #444 once ready.

Happy to review the complete feature when it lands.

@DotDev262 DotDev262 added the gssoc:approved Approved for GSSOC points (Required) label Jun 21, 2026
@sat-06

sat-06 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi @DotDev262

I have implemented the changes and have updated the pr.

Changes included:

  • Added config drift CLI command

  • Added IConfigDriftService and ConfigDriftService

  • Added ConfigDriftResult model for drift reporting

  • Integrated drift detection into the configuration workflow

  • Added backup metadata support (SourcePath)

  • Added unit tests covering:

    • Missing backup file
    • No drift detected
    • Drift detected when settings differ

Validation:

  • dotnet build passes
  • dotnet test passes

This addresses the requested drift detection workflow and reporting functionality from issue #444.

@DotDev262 DotDev262 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full drift detection implementation delivered. Build passes (0 errors, 0 warnings), all 3 drift tests pass. Approved and ready to merge.

@DotDev262 DotDev262 merged commit a181ee8 into DotDev262:main Jun 21, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSOC points (Required) GSSOC GirlScript Summer of Code 2026 level:intermediate Intermediate level task type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Configuration Drift Detection and Reporting

2 participants