Skip to content

fix: resolve ruff import-sort lint error in test_vlc.py#472

Merged
DotDev262 merged 1 commit into
DotDev262:mainfrom
Vishxlll20:fix/vlc-test-import-lint
Jun 22, 2026
Merged

fix: resolve ruff import-sort lint error in test_vlc.py#472
DotDev262 merged 1 commit into
DotDev262:mainfrom
Vishxlll20:fix/vlc-test-import-lint

Conversation

@Vishxlll20

Copy link
Copy Markdown
Contributor

Related Issue

No linked issue — found and fixed while debugging a CI failure on PR #471 (for issue #450).

Proposed Changes

  • Removed an extra blank line in plugins/vlc/test/test_vlc.py between the import block and PLUGIN = ..., which was causing ruff check to fail with I001 Import block is un-sorted or un-formatted
  • This was unrelated to any feature change — it was blocking the lint CI job for every open PR on main, including unrelated ones like docs-only PRs

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 📖 Documentation
  • 🧪 Testing
  • 🛠️ Refactoring
  • 🚀 DevOps/CI

Screenshots / Logs (if applicable)

Before:I001 [*] Import block is un-sorted or un-formatted

--> plugins/vlc/test/test_vlc.py:8:1

Found 1 error.
After:

Testing & Verification

  • I have run dotnet test and all 60+ cross-platform tests passed.
  • I have verified the changes on a Windows environment (if applicable).
  • I have added new unit tests to cover my changes.

GSSOC 2026 Checklist

  • I have read the Contribution Guidelines.
  • My code is formatted correctly.
  • I have linked the PR to an approved issue.
  • I understand that a maintainer must apply the gssoc:approved label for this PR to count for points.

@DotDev262 DotDev262 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial lint fix — removes extra blank line causing ruff import-sort error.

@DotDev262 DotDev262 merged commit 3af934d into DotDev262:main Jun 22, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants