Skip to content

Feature/uac translation#21

Merged
DotNetRussell merged 3 commits into
DotNetRussell:mainfrom
Goultarde:feature/uac-translation
May 21, 2026
Merged

Feature/uac translation#21
DotNetRussell merged 3 commits into
DotNetRussell:mainfrom
Goultarde:feature/uac-translation

Conversation

@Goultarde
Copy link
Copy Markdown
Contributor

@Goultarde Goultarde commented May 20, 2026

Description

Adds human-readable translation of the userAccountControl (UAC) attribute instead of displaying only the raw integer value.

Changes:

  • Added UAC_FLAGS dictionary covering all 22 Microsoft UAC bitmask flags (ACCOUNTDISABLE, DONT_REQ_PREAUTH, TRUSTED_FOR_DELEGATION, etc.)
  • Added decode_uac(value) function returning the format 66050 (ACCOUNTDISABLE, NORMAL_ACCOUNT, DONT_EXPIRE_PASSWORD)
  • Integrated into --inspect: the useraccountcontrol property is now decoded inline
  • Integrated into --kerberoastable, --as-rep-roastable, --password-never-expires, --password-not-required: each listed account now shows its decoded UAC value at the end of the line
image

Goultarde and others added 2 commits May 20, 2026 08:50
Add decode_uac() function with all 22 UAC bitmask flags and integrate
it in inspect_node, kerberoastable, AS-REP roastable, password-never-expires
and password-not-required checks.
@DotNetRussell DotNetRussell self-assigned this May 21, 2026
@DotNetRussell
Copy link
Copy Markdown
Owner

Hey this looks great! Thanks for submitting this.

Can you please add a unit test(s) to verify that the translations are working? I want to make sure no one breaks this when they change stuff.

@DotNetRussell DotNetRussell added the enhancement New feature or request label May 21, 2026
@DotNetRussell DotNetRussell self-requested a review May 21, 2026 13:48
@Goultarde
Copy link
Copy Markdown
Contributor Author

Goultarde commented May 21, 2026

No problem, here it is!
image

@DotNetRussell
Copy link
Copy Markdown
Owner

Perfect thanks!

@DotNetRussell DotNetRussell merged commit 19bcc5f into DotNetRussell:main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants