Fix Color build#1
Open
Striffly wants to merge 2 commits intoDownload:generate-fontfrom
Open
Conversation
572886b to
4f7a91e
Compare
|
@Striffly When we tried to build the fonts with your new code, the colors still don't show. |
Author
|
@thejupitergroup Yes I know, this is part of the remaining bugs that I mentioned in the comment associated with my PR. The goal of this PR is to allow the build of the font with the Color variation (which wasn't possible before), but there is still a lot to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues in the build process of the Fluent UI Emoji project. It introduces support for color builds.
The font is correctly generated, however there is some issues remaining :