Fix force unwrap crash in discover methods#45
Merged
Conversation
added 3 commits
August 19, 2025 14:31
This reverts commit 23e1e02.
DrAma999
approved these changes
Mar 30, 2026
DrAma999
left a comment
DrAma999
left a comment
Owner
There was a problem hiding this comment.
Hello thx.
I understand that force unwrapping is probably not a best practice, but a crash there means that there is no peripheral.
Consider that in that part of the code you are scanning for services and characteristics, this phase can be done only when a peripheral exist, so while this is going to mitigate the issue the actual problem can be elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a crash with a forced unwrap I was seeing with testers.