Skip to content

Bernard's consent review - #10

Open
martinthomson wants to merge 15 commits into
Draft-Mafia:masterfrom
martinthomson:bernard-consent
Open

Bernard's consent review#10
martinthomson wants to merge 15 commits into
Draft-Mafia:masterfrom
martinthomson:bernard-consent

Conversation

@martinthomson

Copy link
Copy Markdown

I've made quite few changes based on Bernard's feedback. The following changes are substantive in some sense:

  • Consent is maintained now by receiving a valid response. Previously, it was receiving a response to one of the checks that were initiated in the 30s window. This change makes it more robust.
  • Requests are abandoned when RTT (+delta) expires or when consent is lost. Requests aren't abandoned by receiving a response to a later request (the unlikely out of order request). This means that there is another timer that runs, in theory (clever implementers will learn that this timer doesn't need to be an actual timer).

Note: Please don't merge this until we conclude the list discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant