Barcelona | Oct2025-2 | Roman Pavlenko | Sprint-3 | Coursework#3
Open
DraftRoman wants to merge 29 commits intomainfrom
Open
Barcelona | Oct2025-2 | Roman Pavlenko | Sprint-3 | Coursework#3DraftRoman wants to merge 29 commits intomainfrom
DraftRoman wants to merge 29 commits intomainfrom
Conversation
In the file
- added if statements
- export function for test environment
- created type.test.js file with the first case for setting engagement
- created a package.json with name/description / scripts for Jest and install Jest "devDependencies": {"jest": "^30.2.0" },
- pachage-lock.json was automatically generated
- we got "Assertion failed: Expected undefined to equal Full rotation" as expected because we don't have statement for this case. - for 180 and 270 everything looking good. - next step fix 360 and try Jest tests
- implemented test cases and fix Full rotation issue - checked in terminal npm test
- the first one is the function for moving Zeros to the end of the array. - the second one is about write a function that takes in a string of one or more words, and returns the same string, but with all words that have five or more letters reversed. - the third one is Create a function taking a positive integer between 1 and 3999 (both included) as its parameter and returning a string containing the Roman Numeral representation of that integer. And in these files are more then just one solution, just tried few solutions of others.
- Fixed statement, and now it's already passed basic cases. - Added test.js with these tests, and it passed. - The nest step add more edge cases, like 0 and what to do. - Create new function to check if it's a half, two-quarters, three-sixths, less or more then.
Stretch tests : - 0, 5 passed the test - 3, -4 passed the test - -2, -3 failed the test, because -3 is less then -2. To fix it I'm going to add one more if statement.
Owner
Author
|
- added if statement for 2 negative numbers. - checked results of the tests. In this case, this is not a problem, but could these changes lead to possible mutations?
Owner
Author
Passed the tests
|
- added module.exports = { getCardValue };
- fixed logic of If statement
- created test.js file and added first test
- first test passed
- expanded the logic of If statement to cover Face Cards - wrote tests for every cand which have a value of 10 - the tests for them covered, the test for 5 was expectedly failed
- for second added denominator equal to zero. - covered by test it - for third test created expect used to Throw method, but have a syntactic error
- fixed if statement form cards <2 and more then 9 - fixed else and throw by google it
- now it's working for negative angles or more then 360 .
- created more tests for edge cases
- covered by seven new tests. - if logic from previous tast
Owner
Author
The card value passed the tests
|
Owner
Author
2-mandatory-rewrite- tests
|
- not exist in string - case-sensetive - single occurrence
And covered it by tests of empty string and invalid argument
Owner
Author
Added Input validation and covered by tests.
|
- all regular cases including any ordinal numbers - cases 13 - 15 are for invalid input such as negative numbers, strings or null / undefined
I'd like to have tests for 11/12/13/14 and 21/22/23/24and for some larger numbers to check scalability
- configured the process logic - everything covered by tests
- fixed for not integer input, and changed in tests case 10, because 1.5 isn't ordinal number. - moved input validation from the loop and made it the first thing to do when function starts.
- strict equal sign - and less lines of code, first three cases together with the rest of code, and default.
-if it's 0 or 1 and error case.
Logic for function: - first validate input - second for loop to implement the repeat function.
- retured the line module.exports = repeat which was deleted.
Owner
Author
Everything in 3-mandatory-practice was done and covered by tests
|
Worked with questions: - a) How the index variable updates during the call to find? - b) What is the if statement used to check - c) Why is index++ being used? - d) What is the condition index < str.length used for?
- Have at least 5 characters. - Have at least one English uppercase letter (A-Z) - Have at least one English lowercase letter (a-z)
- changed the logic of if statement, not to create extra error messages in the function. - covered by the test - now password has to consist >5 letter at least one lowercase, uppercase, number - created one edge case if the password has at least one space.
- added validation to non-alphanumeric symbols - checked the password is unique and haven't used before - the new password will be pushed to the priviesPasswords array and we have a mutation. Maybe better to have here a pure validation and create another function for pushing the password to array based on the value of this function
Were added basic tests: - The password is the same as a previous one - the password passed all requirements and we have the message that the password is strong
Owner
Author
Finished working on password validation and covered it with tests
|
DraftRoman
moved this from 🏗 In progress
to 👀 In review
in Template Coursework Planner Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.