Repository navigation
[pull] master from django-tenants:master - #89
Merged
Merged
Conversation
The command only overrode run_from_argv, so anything reaching it through call_command() fell through to BaseCommand.handle and raised NotImplementedError. It is documented but had no test coverage. - Add handle(), which runs the wrapped command on every tenant. The command line still goes through run_from_argv() so that options belonging to the wrapped command need not be declared here. - --no-public is now removed from argv wherever it appears. It was assumed to sit immediately after the command name, so putting it after the wrapped command's name reported "Unknown command: '--no-public'". - Invoking with no command name silently did nothing; it and --help now hand back to Django's parser, which reports the missing argument and prints usage. - Drop a leftover debug print() of the parsed argv, and the argparse round trip that only ever echoed its input back. Document calling it from Python, including that the wrapped command's own options are command line only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The new tests only drove handle(), so run_from_argv() -- which is what manage.py actually calls -- was untested, leaving 17 lines of the patch uncovered. These drive the command the way manage.py does: passthrough of the wrapped command's own options, --no-public appearing after the command name, an already-loaded BaseCommand instance from get_commands(), and the exit codes for an unknown command, a missing command name and --help. Takes all_tenants_command.py from 48% to 100%. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…-command # Conflicts: # django_tenants/tests/test_commands.py
Django 6.1 was released on 5 August 2026 and requires PostgreSQL 15 or
later. The Postgres compatibility job installs Django unpinned, on purpose
-- the point of that job is the server version, not the Django version --
so as soon as 6.1 reached PyPI the PostgreSQL 14 entry started failing at
connection setup with
NotSupportedError: PostgreSQL 15 or later is required (found 14.23)
before any project code ran. django-tenants still supports Django 5.2,
which supports PostgreSQL 14, so the server is worth testing rather than
dropping. Install the newest series that still accepts it instead.
Also stop the matrix cancelling itself: with fail-fast, PostgreSQL 14
going out of support took 15, 16 and 17 down with it and left nothing to
read. Verified locally: 14 with Django 6.0.8 and 17 with Django 6.1 both
run run_tests.sh clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…o-6.1 Test PostgreSQL 14 against the newest Django that supports it
Give all_tenants_command a handle() so call_command works (#627)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )