BFPopoverColorWell sets itself as cell for popover before showing#11
Open
iljaiwas wants to merge 6 commits intoDrummerB:masterfrom
Open
BFPopoverColorWell sets itself as cell for popover before showing#11iljaiwas wants to merge 6 commits intoDrummerB:masterfrom
iljaiwas wants to merge 6 commits intoDrummerB:masterfrom
Conversation
If there are several ColorWells used, clicking on a second color well made the first clicked color well take on the initial color of the second color well. This change fixes this.
EpicDraws
approved these changes
Oct 21, 2017
EpicDraws
added a commit
to EpicDraws/BFColorPickerPopover
that referenced
this pull request
Oct 21, 2017
Too many other pods with randomColor around.
The old implementation crashes after the second opening of the popover (and do not show the UI) on macOS 13.0. Also, Apple provides a standard popover in Ventura and later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are several ColorWells used, clicking on a second color well made the first clicked color well take on the initial color of the second color well. This change fixes this.