fix(cli): sign manifest last so the .dryadepkg signature verifies (1.1.4)#9
Merged
Conversation
dryade plugin package signed the manifest before adding the sbom field, leaving it outside the signed canonical bytes — the Ed25519 signature on the produced .dryadepkg failed to verify and the package would be rejected at load. Sign last, after hashes + contract_version + sbom are set, so the signature covers the final manifest. Adds a signature round-trip regression test (the gap that let this ship). Co-Authored-By: Dammerzone <dammerzone@users.noreply.github.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
dryade plugin packagesigned the manifest before adding thesbomfield. Since the signed canonical bytes exclude onlysignature/signature_pq, thesbomfield landed outside the signed bytes — so the Ed25519 signature on the produced.dryadepkgdid not verify and the package would be rejected at load. Shipped in 1.1.2 and 1.1.3; no test verified the signature round-tripped.Fix
Sign last, after hashes + contract_version + sbom are all set, so the signature covers the final manifest. Adds
tests/test_package_signature.py(verifies the produced package's signature against the author key + that it coverssbom).Found by driving the published CLI end-to-end (
new→validate→package) and verifying the artifact's signature externally.