initial mapper 30 support, tools and fixes for non-Windows builds#7
Open
asiekierka wants to merge 3 commits intoDwedit:mainfrom
Open
initial mapper 30 support, tools and fixes for non-Windows builds#7asiekierka wants to merge 3 commits intoDwedit:mainfrom
asiekierka wants to merge 3 commits intoDwedit:mainfrom
Conversation
Owner
|
Mapper 30 looks wrong. According to nesdev wiki, you get single screen mirroring with nametable selection when the 4 Screen flag is set, and the Vertical Mirroring flag is cleared. (Which is a bad design choice, as that is how you normally specify 4 screen mirroring!) edit: Also the stack is imbalanced in that code and it will crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on FluBBaOfWard/NesDS#1