Skip to content

Restore visible favorite star state - #84

Merged
RANGROO merged 1 commit into
unstablefrom
codex/favorite-star-contrast
Aug 23, 2026
Merged

Restore visible favorite star state#84
RANGROO merged 1 commit into
unstablefrom
codex/favorite-star-contrast

Conversation

@RANGROO

@RANGROO RANGROO commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore unmistakable gold favorite-star hover, focus, and active states on Dialectic NPC cards and the partial editor
  • keep the existing hollow/filled glyph, button sizing, Fallout branding, and persistence behavior unchanged

Root cause

The NPC page already declared gold favorite states, but the Dialectic button theme forces cream text and clears text shadow with higher-priority declarations.

Implementation

Scope the existing card favorite selectors and protect the partial editor's favorite-only states without changing lock, picture, or delete controls.

Validation

  • Claude Opus 5 independently reviewed the Dialectic cascade and markup
  • php -l ui/core/npc_master.php
  • runtime PHP lint passed through the server deployment
  • git diff --check
  • live hover rendered rgb(255, 215, 0) with the intended gold glow
  • desktop screenshot captured locally
  • 390 x 844 viewport exercised; the existing 18 px page overflow is outside this color-only diff
  • local page returned HTTP 200
  • reviewable diff: 9 changed lines in one PHP file

Compatibility and performance

  • no JavaScript, database, layout, responsive, or Fallout profile behavior changes
  • CSS-only state styling; no measurable runtime or bloat impact

Deployment

Server-only deployment from commit 51d2fcd88de861a7124edf885dcb0dddef59501b completed to /var/www/html/DialecticServer; runtime data was preserved and the deployed file blob matches the source.

Known limits

  • the local dataset has no active favorite, so persistence was not toggled and the filled state was verified from the live loaded CSS rule rather than a database mutation
  • keyboard-focus rule is loaded alongside the verified hover rule, but automated Tab traversal was unavailable in the browser harness
  • no in-game validation; this is server WebUI-only styling

Companion source report/fix: abeiro/HerikaServer#727

Sibling PRs

@RANGROO
RANGROO marked this pull request as ready for review August 23, 2026 20:04
@RANGROO
RANGROO merged commit 640282b into unstable Aug 23, 2026
@RANGROO
RANGROO deleted the codex/favorite-star-contrast branch August 23, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant