Use profile relationship connector for event builds - #91
Merged
Conversation
RANGROO
marked this pull request as ready for review
August 20, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stobe's manual Build from Events endpoint ignored the NPC profile's configured relationship connector whenever the legacy
RELLLM_CONNECTORglobal was absent. It fell back to the first connector instead.For the reported Herika failure, that selected
OpenRouter Defaultrather than the Player Faction profile'sGemini 2.5 Flashrelationship connector. OpenRouter Auto routed the 9,016-token prompt to DeepSeek V4 Flash, which used the full 1,024-token completion on reasoning and returned empty content.Change
relationship_connector.This is separate from #90, which limited the bulk migration scope. This PR fixes the manual per-NPC Build from Events action.
Compatibility
No schema or configuration migration is required.
HerikaServer already loads its global relationship connector for this endpoint. DialecticServer independently bootstraps its global connector, so no sibling port is needed.
Validation
php -l ext/relationship_system/analyze_relationships.phpSTOBE_DB_NAME=stobe_test php tests/relationship_system_regression.phpgit diff --check origin/unstable...HEADGemini 2.5 Flash(google/gemini-2.5-flash).Deployment
Not deployed.
Limits
No live LLM request was made because it would incur an external request and persist relationship data. No browser or in-game validation was performed.