Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions config/index.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
const fs = require('fs')
const paths = require('./paths')
const YAML = require('yamljs')
const merge = require('merge')

module.exports = {
let config = {
paths,
domain: 'https://localhost',
port: 8080,
serveHttps: true,
regex: {
images: /\.(png|svg|jpg|gif)$/,
static: /\.(liquid|json)$/
},
shopify: YAML.load(paths.userShopifyConfig)
}
}

if(fs.existsSync(paths.userServerConfig)) {
config = merge(true, config, YAML.load(paths.userServerConfig))
}

config.devDomain = config.devDomain || `${config.domain}:${config.port}`

config.shopify = YAML.load(paths.userShopifyConfig)

module.exports = config
1 change: 1 addition & 0 deletions config/paths.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,6 @@ module.exports = {
},
assetsOutput: resolveApp('dist/assets'),
userShopifyConfig: resolveApp('config/shopify.yml'),
userServerConfig: resolveApp('config/server.yml'),
eslintrc: getEslintrc()
}
2 changes: 1 addition & 1 deletion config/webpack.dev.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const commonExcludes = require('../lib/common-excludes')
const userWebpackConfig = require('../lib/get-user-webpack-config')('dev')

// so that everything is absolute
webpackConfig.output.publicPath = `${config.domain}:${config.port}/`
webpackConfig.output.publicPath = `${config.devDomain}/`

// add hot-reload related code to entry chunks
Object.keys(webpackConfig.entry).forEach((name) => {
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"img-loader": "2.0.0",
"jest": "20.0.3",
"loader-utils": "1.1.0",
"merge": "^1.1.3",
"minimist": "1.2.0",
"node-sass": "4.5.3",
"postcss-loader": "2.0.5",
Expand Down
5 changes: 4 additions & 1 deletion scripts/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const express = require('express')
const fs = require('fs')
const path = require('path')
const https = require('https')
const http = require('http')
const webpack = require('webpack')
const webpackDevMiddleware = require('webpack-dev-middleware')
const webpackHotMiddleware = require('webpack-hot-middleware')
Expand All @@ -29,7 +30,7 @@ const sslOptions = {
}

const app = express()
const server = https.createServer(sslOptions, app)
const server = config.serveHttps ? https.createServer(sslOptions, app) : http.createServer(app)
const compiler = webpack(webpackConfig)

const shopifyUrl = `https://${config.shopify[env].store}`
Expand Down Expand Up @@ -118,6 +119,8 @@ compiler.plugin('done', (stats) => {
console.log(chalk.green('Compiled successfully!'))
console.log('\nThe app is running at:\n')
console.log(` ${chalk.cyan(previewUrl)}`)
console.log('\nHMR is running at:\n')
console.log(` ${chalk.cyan(config.devDomain)}`)
}

// files we'll upload
Expand Down