document how to setup a sprite loader for use with svg-store#105
Open
lastobelus wants to merge 2 commits into
Open
document how to setup a sprite loader for use with svg-store#105lastobelus wants to merge 2 commits into
lastobelus wants to merge 2 commits into
Conversation
nddery
reviewed
Nov 5, 2017
Contributor
nddery
left a comment
nddery
left a comment
There was a problem hiding this comment.
Thanks a lot -- I like the idea of providing more guidance on how to use this feature, but I'd like the example to align more with the premise of Shopify Pipeline.
| <div data-svgloader='{{ "logos.svg" | asset_url }}'></div> | ||
| ``` | ||
|
|
||
| The sprite loader that comes with [webpack-svgstore-plugin]((https://github.com/mrsum/webpack-svgstore-plugin) won't work out of the box, instead given that you have included the above liquid snippet in your theme, this loader will suffice: |
Contributor
There was a problem hiding this comment.
You have an extra opening parenthesis in the webpack-svgstore-plugin link.
I think we should advocate for writing (and importing) a module instead of putting code directly in a liquid template.
|
|
||
| The sprite loader that comes with [webpack-svgstore-plugin]((https://github.com/mrsum/webpack-svgstore-plugin) won't work out of the box, instead given that you have included the above liquid snippet in your theme, this loader will suffice: | ||
| ``` | ||
| $('[data-svg-loader]').each(function _loadSvg() { |
Contributor
There was a problem hiding this comment.
I'd like for this example not to use jQuery, as we do not include it ourselves. Maybe using the fetch API ?
Also, I think the example should follow the Dyanmo's ESLint config - so for example, functions shouldn't start with an underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.