Integration of the Shopify Gateway#1
Open
thisiscab wants to merge 9 commits into
Open
Conversation
This includes the void, credit and cancel operations. Those are the only once required for our current implementation of Shopify Gateway.
In the end, I feel like ActiveMerchant should be aware of how stuff interact with each others it should not be the job of the gateway. All the logic has been move in the ActiveMerchant Github repository that can access here: https://github.com/DynamoMTL/active_merchant
This also updates to the latest version of the ActiveMerchant
We don't want to pass the full object, we only want to pass what the provider is required to know, nothing more. Also fix the specs to represent those changes.
The methods that are not implemented are methods that will never / not required to be called in our scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add the ShopifyGateway required from the Glossier-Retail app to refund / void Shopify order imported on Solidus.