Skip to content

feat(docker): docker compose で別バージョンタグをビルド可能にする #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanasess wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

feat(docker): docker compose で別バージョンタグをビルド可能にする #1405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,18 @@ volumes:

services:
ec-cube:
### ローカルでビルドする場合は以下のコマンドを使用します
## docker build -t ec-cube2 --no-cache --pull --build-arg TAG=8.1-apache .
## docker tag ec-cube2 ghcr.io/ec-cube/ec-cube2-php:8.1-apache
### 通常は image をレジストリから pull します。
### 別バージョンタグをローカルでビルドする場合は TAG を指定して build を実行します:
## TAG=8.3-apache docker compose build
## TAG=8.3-apache docker compose build --no-cache # キャッシュを使わず再ビルド
## TAG=8.3-apache docker compose up -d --build # ビルドして起動
Comment on lines +17 to +19
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

運用コマンド例は COMPOSE_FILE 前提を明記してください。

Line 17-19 の例だと DB バックエンド切替の前提が抜けるため、ガイドライン運用とズレます。コメント例に COMPOSE_FILE を含めた方が安全です。

差分案 
-    ##   TAG=8.3-apache docker compose build
-    ##   TAG=8.3-apache docker compose build --no-cache   # キャッシュを使わず再ビルド
-    ##   TAG=8.3-apache docker compose up -d --build       # ビルドして起動
+    ##   COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose build
+    ##   COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose build --no-cache   # キャッシュを使わず再ビルド
+    ##   COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose up -d --build       # ビルドして起動

As per coding guidelines, "docker-compose*.yml: Use Docker Compose with environment variables (COMPOSE_FILE) to set up the correct database backend (MySQL 8.4 or PostgreSQL 16)".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## TAG=8.3-apache docker compose build
## TAG=8.3-apache docker compose build --no-cache # キャッシュを使わず再ビルド
## TAG=8.3-apache docker compose up -d --build # ビルドして起動
## COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose build
## COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose build --no-cache # キャッシュを使わず再ビルド
## COMPOSE_FILE=docker-compose.yml:docker-compose.${DB}.yml:docker-compose.dev.yml TAG=8.3-apache docker compose up -d --build # ビルドして起動
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.yml` around lines 17 - 19, The sample docker-compose commands
in docker-compose.yml lack the required COMPOSE_FILE environment variable to
select the DB backend; update those examples to show setting COMPOSE_FILE to
include the base compose file plus the DB-specific override (e.g.
COMPOSE_FILE=docker-compose.yml:docker-compose.mysql.yml or
COMPOSE_FILE=docker-compose.yml:docker-compose.postgres.yml) and then run the
same commands (build, build --no-cache, up -d --build) after that prefix so
users explicitly choose MySQL 8.4 or PostgreSQL 16 when using the examples.

image: ${REGISTRY:-ghcr.io}/${IMAGE_NAME:-ec-cube/ec-cube2-php}:${TAG:-8.1-apache}
pull_policy: missing # ローカルに無ければ build ではなく pull する
build:
context: .
args:
TAG: ${TAG:-8.1-apache}
pull: true
volumes:
### 同期対象からコストの重いフォルダを除外 #####################
- "vendor:/var/www/app/data/vendor"
Expand Down
Loading