feat: add spec2vec_allowed_missing_percentage parameter#34
Open
arnelammers wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the spec2vec_allowed_missing_percentage parameter to the SpecReboot workflow, including updated documentation.
This parameter allows the maximum percentage of missing peaks allowed in the spec2vec similarity calculation to be customizable. Prevents failed similarity calculations due to vocabulary gaps, particularly in specific cases involving self-trained models. It is also important when working with specific (e.g. environmental non-target) data where the default missing percentage threshold of 5 might be too strict for unrepresented spectra.