Skip to content

Rework conditions#71

Draft
Fizzadar wants to merge 4 commits intomasterfrom
rework-conditions
Draft

Rework conditions#71
Fizzadar wants to merge 4 commits intomasterfrom
rework-conditions

Conversation

@Fizzadar
Copy link
Copy Markdown
Contributor

@Fizzadar Fizzadar commented Oct 8, 2020

WIP! New conditions implementation that actually makes sense:

name: my-project
configVersion: 1
requireKubetools: '~=12.0'  # optional, replacement for minKubetoolsVersion

deployments:
  app-name:
    conditions:
      dev:  true  # default
      test: true  # default
      deploy:
        - env: 'production'
          namespace: 'A'
        - env: 'backup'
          namespace: 'B'

Closes: #64

Nick Barrett added 2 commits October 8, 2020 10:48
This replaces `minKubetoolsVersion` (maintaining backwards compatibility)
and enables tracking of config version.
@Fizzadar Fizzadar self-assigned this Oct 8, 2020
Nick Barrett added 2 commits October 9, 2020 14:37
This maintains backwards compatibility by passing the old `KUBE_ENV`
environment variable as before, in additino to the new `KUBE_CONTEXT`.

The move makes "context" the consistent method by which a target cluster
is chosen - this is entirely a deploy tooling specific thing as K8s
clusters don't have names. This means that the use of context and the
`KUBE_CLUSTER` envvar are at the discretion of the individual or team
using the tool as a way to differentiate between multiple clusters.
@Fizzadar Fizzadar marked this pull request as ready for review October 9, 2020 13:43
@Fizzadar Fizzadar marked this pull request as draft November 10, 2020 13:41
@Fizzadar Fizzadar removed their assignment Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework/improve conditions

1 participant