Draft
Conversation
added 2 commits
October 8, 2020 10:48
This replaces `minKubetoolsVersion` (maintaining backwards compatibility) and enables tracking of config version.
Based on the discussion @ #64.
added 2 commits
October 9, 2020 14:37
This maintains backwards compatibility by passing the old `KUBE_ENV` environment variable as before, in additino to the new `KUBE_CONTEXT`. The move makes "context" the consistent method by which a target cluster is chosen - this is entirely a deploy tooling specific thing as K8s clusters don't have names. This means that the use of context and the `KUBE_CLUSTER` envvar are at the discretion of the individual or team using the tool as a way to differentiate between multiple clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP! New conditions implementation that actually makes sense:
Closes: #64