Repository navigation
added first version of landing page - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial static landing page for the e-Vote project, providing a sign-in/register/OTP UI and a marketing panel to communicate the product’s positioning.
Changes:
- Introduces a complete landing page layout (top bar, split panel UI, and multiple views for auth flows).
- Adds inline CSS for styling and responsive behavior.
- Adds inline JavaScript for view switching, basic form handling, OTP timer, and toast notifications.
Comments suppressed due to low confidence (3)
index.html:1197
- This link uses href="#" but doesn’t prevent the default navigation, so clicking it will jump to the top of the page in addition to showing the toast.
<a class="forgot-link" href="#"
onclick="showToast('Password reset link sent to your registered email.')">Forgot
password?</a>
index.html:1278
- Same issue here: this has no href, so it won’t be keyboard-focusable. Make it an actual link (or a button) so users can navigate via keyboard/screen reader.
<div class="f-footer">Already have an account? <a onclick="switchTab('login')">Sign in</a></div>
index.html:1533
- The OTP handler currently treats any character as a “filled” digit and verifyOtp() only checks length, so non-digits (e.g. “ABCDEF”) can be accepted as a complete code. Sanitize each box to a single digit before marking it filled / moving focus.
boxes.forEach((b, i) => {
b.value = ""; b.classList.remove("filled");
b.oninput = () => { b.classList.toggle("filled", b.value.length > 0); if (b.value && i < boxes.length - 1) boxes[i + 1].focus(); };
b.onkeydown = ev => { if (ev.key === "Backspace" && !b.value && i > 0) boxes[i - 1].focus(); };
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+13
| <link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | ||
| <link href="https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700;800;900&display=swap" | ||
| rel="stylesheet" /> |
Comment on lines
+1115
to
+1118
| <nav class="t-nav"> | ||
| <a class="t-link" href="#">How it works</a> | ||
| <a class="t-link" href="#">Security</a> | ||
| <a class="t-link" href="#">About</a> |
| </button> | ||
| </form> | ||
|
|
||
| <div class="f-footer">New to e-Vote? <a onclick="switchTab('register')">Create an account</a></div> |
Comment on lines
+1300
to
+1305
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o1" /> | ||
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o2" /> | ||
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o3" /> | ||
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o4" /> | ||
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o5" /> | ||
| <input class="otp-box" type="text" maxlength="1" inputmode="numeric" id="o6" /> |
| <line x1="12" y1="8" x2="12" y2="12" /> | ||
| <line x1="12" y1="16" x2="12.01" y2="16" /> | ||
| </svg> | ||
| Please enter a valid Student ID or email address. |
|
|
||
| <div class="otp-timer-row"> | ||
| <span class="otp-t">Expires in <span class="otp-t-val" id="timerDisplay">05:00</span></span> | ||
| <button class="otp-resend" onclick="resetTimer()">Resend code</button> |
| </main> | ||
|
|
||
| <!-- Toast --> | ||
| <div class="toast" id="toast"> |
| </section> | ||
|
|
||
| <!-- ━━ RIGHT PANEL ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ --> | ||
| <aside class="panel-r" aria-hidden="true"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.