Skip to content

Add analysis mode for Sentinel-3 SLSTR RBT product#62

Merged
konstntokas merged 9 commits into
mainfrom
konstntokas-016-add_sen3_slstr_rbt
Oct 23, 2025
Merged

Add analysis mode for Sentinel-3 SLSTR RBT product#62
konstntokas merged 9 commits into
mainfrom
konstntokas-016-add_sen3_slstr_rbt

Conversation

@konstntokas
Copy link
Copy Markdown
Collaborator

@konstntokas konstntokas commented Oct 22, 2025

Closes #16

  • Sentinel-3 SLSTR Level-1 RBT products are now supported in analysis mode. This
    allows data from bands A, B, F, and I — in both nadir and oblique viewing
    geometries — to be represented on a unified grid within a single dataset.
  • Sentinel-3 SLSTR datasets are now terrain-corrected using the elevation
    information provided within the product itself.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
xarray_eopf/amodes/sentinel2.py 100.00% <100.00%> (ø)
xarray_eopf/amodes/sentinel3.py 100.00% <100.00%> (ø)
xarray_eopf/backend.py 100.00% <100.00%> (ø)
xarray_eopf/constants.py 100.00% <100.00%> (ø)
xarray_eopf/version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@konstntokas konstntokas requested a review from TonioF October 22, 2025 12:36
@TonioF
Copy link
Copy Markdown
Contributor

TonioF commented Oct 22, 2025

Code looks good, but when I tried to run the example notebook, I received a FileNotFoundError. Do you have an idea what's going on?

@konstntokas
Copy link
Copy Markdown
Collaborator Author

Code looks good, but when I tried to run the example notebook, I received a FileNotFoundError. Do you have an idea what's going on?

Did this happen for the Sentinel-3 OLCI Level-2 LFR product?

Unfortunately, they deprecated this example. I selected a new one. Update will come.

@TonioF
Copy link
Copy Markdown
Contributor

TonioF commented Oct 23, 2025

Code looks good, but when I tried to run the example notebook, I received a FileNotFoundError. Do you have an idea what's going on?

Did this happen for the Sentinel-3 OLCI Level-2 LFR product?

Unfortunately, they deprecated this example. I selected a new one. Update will come.

No, I directly went to test the SLSTR L1 B product. I can't make statements about the others.

@konstntokas
Copy link
Copy Markdown
Collaborator Author

Code looks good, but when I tried to run the example notebook, I received a FileNotFoundError. Do you have an idea what's going on?

Did this happen for the Sentinel-3 OLCI Level-2 LFR product?
Unfortunately, they deprecated this example. I selected a new one. Update will come.

No, I directly went to test the SLSTR L1 B product. I can't make statements about the others.

Same problem for SLSTR L1 RBT product. I also exchanged the example there. All the examples are running now. see uodated open_sen3.ipynb.

Copy link
Copy Markdown
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. One thing about the datatree attributes in the notebook: Those seemed quite unusable. Is it possible to organise them in dictionaries?

Comment thread CHANGES.md Outdated
Comment thread docs/guide.md Outdated
konstntokas and others added 2 commits October 23, 2025 14:56
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
@konstntokas
Copy link
Copy Markdown
Collaborator Author

Overall, it looks good to me. One thing about the datatree attributes in the notebook: Those seemed quite unusable. Is it possible to organise them in dictionaries?

Yes the attributes are awful. Already discussed within the consortium. But they want to keep it this way. So for native mode, we will present them as is. For analysis mode, we already modify them by removing the stac_discovery dictionary, and present the other_metadata so that it renders nicely. See: https://github.com/EOPF-Sample-Service/xarray-eopf/blob/main/xarray_eopf/amodes/sentinel3.py#L118. After Sentinel-1 implementation, we will see if we can unify the attributes for all three products somehow.

@konstntokas konstntokas merged commit 6f8d2ec into main Oct 23, 2025
2 checks passed
@konstntokas konstntokas deleted the konstntokas-016-add_sen3_slstr_rbt branch October 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement analysis mode for Sentinel-3 SLSTR Level-1 RBT

2 participants