Bug Fix: Finds crs in the datatree meta data#64
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
forman
left a comment
forman
left a comment
There was a problem hiding this comment.
Treat as improved. Take my suggestions, if you like.
| Args: | ||
| datatree: The DataTree containing metadata in its attributes. | ||
|
|
||
| Returns: |
There was a problem hiding this comment.
It is actually Return, not Returns.
| Returns: | |
| Return: |
There was a problem hiding this comment.
But Google Style docstrings says Returns, see https://www.geeksforgeeks.org/python/python-docstrings/, or do I miss something here?
| @@ -1,9 +1,16 @@ | |||
| ## Changes in 0.2.4 (under development) | |||
|
|
|||
| * Bug fix: CRS information is missing in Sentinel-2 product data variables since | |||
There was a problem hiding this comment.
| * Bug fix: CRS information is missing in Sentinel-2 product data variables since | |
| * Fix: CRS information is missing in Sentinel-2 product data variables since |
If at all it was a bug in the dataset not in the software.
There was a problem hiding this comment.
Agreed, changed it.
konstntokas
force-pushed
the
konstntokas-063-grid_mapping_sen2_not_found
branch
from
c94699f to
42dd016
Compare
|
Reviewing the thread from EOPF-Sample-Service/eopf-sample-data#16, I was somewhat surprised that the updates in the CPM had not been reflected in the Zarr samples service earlier. I suspect this may be due to a communication gap from the re-engineering team regarding the implications of the new release. To improve coordination moving forward, I initiated a discussion on EOPF discourse. |
3 participants
CPM v2.6.2. CRS is now correctly read from the dataset’s
other_metadataattributes in the datatree.
@forman I ran
ruff, which is the reason why so many files have been changed. Please focus on the files inxarray_eopf.closes #63