Add analysis mode for Sentinel-1 Level-2 OCN#83
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
pont-us
left a comment
pont-us
left a comment
There was a problem hiding this comment.
I have one nitpicky rephrasing suggestions, and one query about unit correctness. But I don't need to review again once these are attended to, so approving in advance.
| if resolution is None: | ||
| if crs and not crs.is_geographic: | ||
| center_lat = (source_gm.xy_bbox[1] + source_gm.xy_bbox[3]) / 2 | ||
| resolution = resolution_degrees_to_meters(source_gm.xy_res, center_lat) |
There was a problem hiding this comment.
Shouldn't the resolution in this case be in the units of the output CRS rather than always in metres?
There was a problem hiding this comment.
No, in the case the user sets e.g. crs="EPSG:32631" (UTM 31 N) and does not give any resolution, then the resolution is derived from the source_gm. Now the source gridmapping has lat / lon and xy_res in degree, because the geolocation in the product is given in geographic coordinates. Therefore, we need to transform from degrees to meters.
Co-authored-by: Pontus Lurcock <pont@talvi.net>
2 participants
Add support for Sentinel-1 Level-2 OCN analysis mode.