Conversation
Add a new job for sqlalchemy 2.0 and fixed all issues. RFDAP-8594
lvoliveira
force-pushed
the
fb-RFDAP-8594-add-support-for-sqlalchemy20
branch
from
ef2aaa6 to
c987a7a
Compare
|
lincrosenbach
left a comment
lincrosenbach
left a comment
There was a problem hiding this comment.
Is this change on format wanted?
| from .field import Field | ||
| from .field import NestedAttributesField | ||
| from .field import NestedModelField | ||
| from .field import PrimaryKeyField |
There was a problem hiding this comment.
Not grouping imports anymore?
There was a problem hiding this comment.
I can change the rules, I have just run the linter and it updated the formatting. We are not running the lint step on CI. I'm submitting another PR to do that. But I can adjust that rule here already.
There was a problem hiding this comment.
Humm, I checked here and that is done by the reorder_python_imports plugin configured on pre-commit. Check the formatting here. It already respect that rule.
I will keep the changes here and maybe we can think of opening a PR to change the use of reorder_python_imports and black by ruff and then we can configure other rules we want.
4 participants
Add a new job for sqlalchemy 2.0 and fixed all issues.
RFDAP-8594