Dynamic Font 적용#618
Merged
Merged
Conversation
HyeonjinBack
requested review from
aldalddl,
ibcylon,
jihyeonjjang,
kanghun1121,
kitcat-s and
leekangho0
# Conflicts: # AIProject/iCo/Features/MyPage/View/Bookmark/BookmarkView.swift # AIProject/iCo/Features/MyPage/View/Bookmark/BriefingSectionView.swift # AIProject/iCo/Features/MyPage/View/CoinListSectionView.swift
HyeonjinBack
force-pushed
the
refactor/dynamicFont-HJB
branch
from
6920760 to
a99806d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
info.plist에서 암호화 사용 알고리즘 안나오게 추가
dynamic font 적용
기존의 고정된 폰트 사이즈 코드에서 크게 벗어나지 않게 하기 위해서 파라미터로 기존의 폰트 사이즈는 받되, 다이내믹 폰트의 비율 대로 스케일링 할 수 있도록 UIFontMetrics를 사용했습니다. (iCO / Core / Util / AppFont)
시스템 설정에서 글자 크기를 최대 크기로 했을 경우 List나 LazyVStack가 심하게 망가져서 텍스트 높이의 최대 크기는 1.8배를 기본값으로 설정해 두었습니다.
💬 리뷰 요구사항(선택)
모든 뷰에 적용 시켜 놓으려고 했는데 무서워서 일단 제가 작성한 뷰에만 적용 했습니다.ㅎㅎ.
추가적으로 AppFont의 파일 위치가 Core / Util에 들어가는게 맞을까요?