Conversation
Make bash default values visible to the Python command builder so manual deploy dispatch can reach AWS SSM after OIDC succeeds. Constraint: GitHub Actions proved the shared GitHubActionsRole can authenticate, but the dispatcher failed locally on an unexported timeout default. Rejected: Setting only a workflow env default | the script should be robust when run through npm or a shell. Confidence: high Scope-risk: narrow Directive: Keep dispatcher defaults exported whenever Python reads them from os.environ. Tested: bash -n scripts/dispatch-ec2-deploy-ssm.sh; git diff --check. Not-tested: Live EC2 dispatch until this patch reaches main. Related: #3 Co-authored-by: OmX <omx@oh-my-codex.dev>
Merge PR #10 to fix dispatcher env defaults before rerunning EC2 deploy.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Follow-up for #3.