Fix Google Maps deploy path and Action-based rollout#25
Merged
Conversation
Constraint: keep existing AMI/runtime flow and not change app business logic. Added a profile-gated Caddy container, env propagation, and deploy vars so HTTPS can be used as temporary temporary endpoint. Constraint: ca-central-1 EC2 deployment path only Rejected: adding separate ingress controller stack | too much operational complexity for MVP Confidence: medium Scope-risk: moderate Directive: keep Caddy profile disabled unless TOMATONO_SSLIP_HOST is set. Tested: Deploy workflow command path passes env and starts compose with profile; curl to https sslip endpoint returns 200. Not-tested: production TLS renewal behavior under load
Constraint: keep route-screen operability even when Google Maps key/domain validation fails Rejected: disabling Google map completely | would block core map-preview feature Confidence: high Scope-risk: narrow Tested: npm run lint Not-tested: CI and runtime EC2 verification pending
Constraint: map preview must be visible before Google Maps key/domain is validated Rejected: leaving empty map container when API key is present but route data lacks coordinates | poor operator visibility Confidence: high Scope-risk: narrow Tested: npm run lint Not-tested: runtime visual check pending
Constraint: map surface must render whenever key is present to verify rendering independently of payload coordinates Rejected: blocking map render when coordinates are missing | would hide map availability Confidence: high Scope-risk: narrow Tested: npm run lint, npm run build Not-tested: EC2 deployment and live browser verification
Fix the workflow-dispatch branch fallback so manual runs can deploy the selected ref instead of silently deploying main. Keep EC2 .env preserved while applying deploy-time values provided by Actions, including Google Maps and sslip.io settings.\n\nConstraint: EC2 rollout still uses SSM Run Command behind GitHub Actions because the instance is managed through SSM, not direct SSH.\nRejected: Continuing local aws ssm commands for normal deploys | It bypasses branch, secret, and audit consistency.\nConfidence: high\nScope-risk: narrow\nDirective: Use direct SSM only as emergency/debug fallback; normal deploys go through deploy-ec2.\nTested: bash -n scripts/dispatch-ec2-deploy-ssm.sh scripts/ec2-bootstrap-and-deploy.sh; npm run lint; npm test; npm run build\nNot-tested: main push auto deploy until this branch is merged to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification