Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Migrate BaseCamp devcontainer into EVerest devcontainer#63

Merged
andistorm merged 2 commits intomainfrom
feat/dev_container_refactor
Dec 8, 2025
Merged

Migrate BaseCamp devcontainer into EVerest devcontainer#63
andistorm merged 2 commits intomainfrom
feat/dev_container_refactor

Conversation

@florinmihut
Copy link
Contributor

@florinmihut florinmihut commented Oct 22, 2025

  • Add devrd script
    • This introduces a couple of features like managing multiple containers, nodered flows and allowing devcontainer usage without vscode
  • Add bash/zsh completion

@florinmihut florinmihut requested a review from andistorm October 22, 2025 08:03
@florinmihut florinmihut force-pushed the feat/dev_container_refactor branch from a64de81 to 8e24761 Compare October 24, 2025 08:40
@florinmihut florinmihut marked this pull request as ready for review October 24, 2025 08:43
@florinmihut florinmihut force-pushed the feat/dev_container_refactor branch from 49d7f7a to 6dd08c0 Compare October 27, 2025 11:28
Copy link
Member

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general layout looks really good to me! Unfortunately I wasn't able to test it yet, I plan to do so in next feedback loop

  • I made a lot of comments regarding naming and inline comments. I think this is quite important especially in a bash script environenment that is hard to read and error-prone.
  • A lot of things should be moved to the dev-env-base image instead of being duplicated here.
  • Discuss: What happens when the nodered service is running and someone uses a run nodered script? I would vote for removing one of those options sop it is clear how to use nodered as service for everest sil

  • Documentation: The README.md is way to big. It's contents + REQUIREMENTS.md should be moved to the main documentation. The README should only include hints about what is inside this repository and roughly how to work with the repos contents and a link to the main documentation. So the usage of devcontainer tooling belongs to main documentation. I would suggest to split the devcontainer docs into the following chunks in the new upcoming docs structure:

    • Tutorial: How to setup first devcontainer/dev environment and start sil or so
    • How to guide: A bit advanced features as starting/stopping services using other profiles, using environemt variables, all the available commands
    • Explanation: How does the devcontainer works: devcontainer vs docker compose, ports, all the stuff in the background which a developer would need to work on the tooling
    • Reference: The Requirements could be protocol

led here as reference, but could also be omitted in my opinion. We only talked about F1-F7

  • The old documentation should be removed/adapted
  • Documentation should fit to the general getting started guide. Either it should replace it, extend it or link against each other
  • Are there already related PRs in the corresping repositories I have overseen?

If you have any questions on my comments we also can set up a call to discuss it

Copy link
Member

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general layout looks really good to me! Unfortunately I wasn't able to test it yet, I plan to do so in next feedback loop

  • I made a lot of comments regarding naming and inline comments. I think this is quite important especially in a bash script environenment that is hard to read and error-prone.
  • A lot of things should be moved to the dev-env-base image instead of being duplicated here.
  • What happens when the nodered service is running and someone uses a run nodered script? I would vote for removing one of those options sop it is clear how to use nodered as service for everest sil
  • Documentation: The README.md is way to big. It's contents + REQUIREMENTS.md should be moved to the main documentation. The README should only include hints about what is inside this repository and roughly how to work with the repos contents and a link to the main documentation. So the usage of devcontainer tooling belongs to main documentation. I would suggest to split the devcontainer docs into the following chunks in the new upcoming docs structure:
    • Tutorial: How to setup first devcontainer/dev environment and start sil or so
    • How to guide: A bit advanced features as starting/stopping services using other profiles, using environemt variables, all the available commands
    • Explanation: How does the devcontainer works: devcontainer vs docker compose, ports, all the stuff in the background which a developer would need to work on the tooling
    • Reference: The Requirements could be protocolled here as reference, but could also be omitted in my opinion. We only talked about F1-F7
  • The old documentation should be removed/adapted
  • Documentation should fit to the general getting started guide. Either it should replace it, extend it or link against each other
  • Are there already related PRs in the corresping repositories I have overseen?

If you have any questions on my comments we also can set up a call to discuss it

@andistorm
Copy link
Member

Please add proper title and description to this PR

@florinmihut florinmihut force-pushed the feat/dev_container_refactor branch from 40a3c45 to 2688319 Compare November 12, 2025 12:33
…yard) tool to handle the containers

Signed-off-by: florinmihut <florinmihut1@gmail.com>
@florinmihut florinmihut force-pushed the feat/dev_container_refactor branch from b95621c to 409eb33 Compare November 14, 2025 08:09
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@andistorm andistorm changed the title Initial version Migrate BaseCamp devcontaine rinto EVerest devcontainer Dec 8, 2025
@andistorm andistorm changed the title Migrate BaseCamp devcontaine rinto EVerest devcontainer Migrate BaseCamp devcontainer into EVerest devcontainer Dec 8, 2025
Copy link
Member

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧 While still some aspects need a bit of rework this PR can be merged and further changes can be done in the monorepo

@andistorm andistorm merged commit 2289889 into main Dec 8, 2025
34 of 47 checks passed
@andistorm andistorm deleted the feat/dev_container_refactor branch December 8, 2025 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants