refactor: extract shadow control-plane into standalone omo-control-plane service#40
Open
EZotoff wants to merge 2 commits into
Open
refactor: extract shadow control-plane into standalone omo-control-plane service#40EZotoff wants to merge 2 commits into
EZotoff wants to merge 2 commits into
Conversation
Extracted to omo-control-plane as a standalone service. Removes createShadowControlPlane import, instantiation, and three /control-plane* API routes from omo-pulse's API server. Increases Bun.serve idleTimeout to 255s to prevent disconnection on slow first payload.
Control-plane tests now live in omo-control-plane. Removes vi.mock for ../server/control-plane, four control-plane route test cases, and the deleted control-plane.test.ts reference from the test suite.
There was a problem hiding this comment.
Pull request overview
Refactors omo-pulse by removing the embedded “shadow control-plane” functionality so orchestration/advisory logic can live in the standalone omo-control-plane service, and adjusts server keep-alive behavior to better tolerate slow first responses.
Changes:
- Removes embedded control-plane wiring/routes/tests from
omo-pulse(leaving monitoring/dashboard concerns in this repo). - Increases Bun server
idleTimeoutto 255s in both dev + start entrypoints. - Updates API/test code organization and lockfile metadata as part of the refactor.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/start.ts | Sets Bun idleTimeout to 255s for longer-lived connections in the prod entrypoint. |
| src/server/dev.ts | Sets Bun idleTimeout to 255s for the dev API server. |
| src/server/api.ts | Removes control-plane-related API surface (and reformats/organizes API module). |
| src/tests/api.test.ts | Removes/adjusts API route tests and mocking to match the new API surface. |
| bun.lock | Adds configVersion metadata (lockfile format update). |
[RISK:medium]
[SCORES]
{"security":4.5,"safety":4.5,"performance":3.5,"featureQuality":4.0,"confidence":3.5}
[/SCORES]
[SUMMARY]
The extraction/refactor direction looks consistent with the stated separation-of-concerns goal, and repo-wide searches show no remaining control-plane references. The main follow-ups are operational/maintainability oriented: make the new max idleTimeout configurable/documented, and prefer type-safe Vitest mocking helpers over unknown casts.
[/SUMMARY]
| fetch: app.fetch, | ||
| hostname: "127.0.0.1", | ||
| port, | ||
| idleTimeout: 255, |
| fetch: app.fetch, | ||
| hostname: "127.0.0.1", | ||
| port, | ||
| idleTimeout: 255, |
Comment on lines
+69
to
+71
| const mockedCreateMultiProjectService = createMultiProjectService as unknown as { | ||
| mockReturnValue: (value: unknown) => void | ||
| } |
Comment on lines
+159
to
163
| ;(listSources as unknown as { mockReturnValue: (value: unknown) => void }).mockReturnValue([ | ||
| { id: "src-1", label: "My Project", updatedAt: 1000 }, | ||
| ]) | ||
| vi.mocked(getDefaultSourceId).mockReturnValue("src-1") | ||
| ;(getDefaultSourceId as unknown as { mockReturnValue: (value: unknown) => void }).mockReturnValue("src-1") | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the shadow control-plane from
omo-pulseinto a new standalone service:omo-control-plane.Why
omo-pulsehandles monitoring and dashboard data;omo-control-planehandles orchestration advisories.What changes
src/server/control-plane/module (5 files)src/server/api.tssrc/__tests__/api.test.tsBun.serveidleTimeoutto 255s (prevents disconnection on slow first payload)The new service
omo-pulse /api/projectsRollback
Reverting this commit restores the embedded control-plane. The extracted service is additive —
omo-pulsehas zero runtime dependency on it.