Conversation
The labels were drawn four pixels above the plot's bottom edge, which with the font's descent put them flush against the edge of the bitmap. The host scales the image into a slot of its own choosing and crops the top and bottom to fit, so they were cut away entirely and the graph carried no time axis at all. Give them their own inset rather than widening the existing edge margin, which also guards the gridline value labels: those are placed by the data, so a larger margin there just drops more of them, and a clipped value label still leaves its gridline behind where a clipped time label leaves nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The redraw interval was measured from when the last bitmap happened to be drawn. A poll can notice a reading up to a full interval after it arrived, so stamping the clock at render time left the next redraw permanently short of the floor: every reading was held for an extra poll and some were skipped, while the image still only ever changed once per reading. Measure against the readings' own timestamps instead, at just under sensor cadence so ordinary jitter doesn't cost a redraw. A unit or threshold change now redraws at once — under a reading-time rule it would otherwise stay hidden until the next reading, which on a sensor gap could be a long while. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.